[Tech] Make IPC typing simpler & more expandable #3819
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
"new" here is a bit loose, as this inherits most of its type definition from the .d.ts file, just changing how TS views it. This replaces our old approach (overwriting electron's types) with a layer on top of the existing IPC. This should play nicer with IDE intellisense, and allows us to make changes to IPC very easily in the future (we can now for example move the `event` parameter to the end of the parameter list passed to the backend, or pass an abort controller to every handler) In the process of moving the actual type definitions, I've also corrected a few mistakes (which weren't caught before, as TS doesn't check .d.ts files)
CommandMC
added
pr:wip
CommandMC
requested review from
arielj,
flavioislima,
Etaash-mathamsetty,
Nocccer and
imLinguin
and removed request for
a team
CommandMC
force-pushed
the
feat/ipc-types
branch
from
60221f1
to
c133c2d
Compare
`removeApp` does the same thing as `uninstall`, so this can just be a handler invoker for `uninstall` This also removes `removeApp`
- This is where they should be (the preload should be as simple as possible) - This was hiding that the current `updateGame` handler was actually unused
The Frontend already filters this to only registered appNames Ideally this would be refactored to go in a Zustand store, but one thing at a time
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
IPC type-checking has always been a bit of a hack job, this is a POC to improve it (for both us and our IDEs). Details are in the first commit message.
This will have issues right now, since I did not go through and convert everything to the new system (figured I'd get some opinions first).This should work fine, if the entire changelist is too overwhelming, you might want to only read until 6915bcb
Use the following Checklist if you have changed something on the Backend or Frontend: