Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Fix] Make the compatibility_layers test work on systems with Wine installed #3847

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

[Fix] Make the compatibility_layers test work on systems with Wine installed #3847

wants to merge 1 commit into from

Conversation

CommandMC
Copy link
Collaborator

This test assumed that Wine is not installed, which works fine in CI, but not on most "real" systems

Use the following Checklist if you have changed something on the Backend or Frontend:

  • Tested the feature and it's working on a current and clean install.
  • Tested the main App features and they are still working on a current and clean install. (Login, Install, Play, Uninstall, Move games, etc.)
  • Created / Updated Tests (If necessary)
  • Created / Updated documentation (If necessary)

@CommandMC
Make the compatibility_layers test work on systems with Wine installed
5f1c484 
This test assumed that Wine is not installed, which works fine in CI, but not on
 most "real" systems
@CommandMC CommandMC added the pr:ready-for-review Feature-complete, ready for the grind! :P label Jul 2, 2024
@CommandMC CommandMC requested a review from a team July 2, 2024 10:10
@CommandMC CommandMC self-assigned this Jul 2, 2024
@CommandMC CommandMC requested review from arielj, flavioislima, Etaash-mathamsetty, Nocccer and imLinguin and removed request for a team July 2, 2024 10:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arielj arielj Awaiting requested review from arielj arielj was automatically assigned from Heroic-Games-Launcher/development

@flavioislima flavioislima Awaiting requested review from flavioislima flavioislima was automatically assigned from Heroic-Games-Launcher/development

@Etaash-mathamsetty Etaash-mathamsetty Awaiting requested review from Etaash-mathamsetty Etaash-mathamsetty was automatically assigned from Heroic-Games-Launcher/development

@Nocccer Nocccer Awaiting requested review from Nocccer Nocccer was automatically assigned from Heroic-Games-Launcher/development

@imLinguin imLinguin Awaiting requested review from imLinguin imLinguin was automatically assigned from Heroic-Games-Launcher/development

At least 1 approving review is required to merge this pull request.

Assignees

@CommandMC CommandMC

Labels
pr:ready-for-review Feature-complete, ready for the grind! :P
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@CommandMC