Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Tech] Download helper binaries instead of storing them in the repo #3849

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

CommandMC
Copy link
Collaborator

Storing Legendary, gogdl, and Nile in this repo directly meant that updating them increases the size of our .git folder substantially. This is not a sustainable solution.
Instead, we now download them from GitHub, using nightly.link as a middle-man (to avoid authenticating). Subsequently, the current binaries were deleted.

Where exactly the binaries come from is tracked using a run ID stored in the update script (meta/downloadHelperBinaries.ts). Thus, changing this is as easy as changing that ID & re-running pnpm download-helper-binaries.

The current workflow run IDs point to the latest ones available in their respective repositories. As such, this PR updates Legendary and gogdl (resolving issues with EA app detection and repeated "Galaxy Common Redistributables" downloads).

You will have to run pnpm download-helper-binaries manually when testing this PR / after it's merged, as well as every time the run ID changes. I opted for not doing this automatically to lessen the load on nightly.link, as the script currently does not check whether the binaries have actually changed (a follow-up PR might change this).

Closes #3846
Closes #3833


Use the following Checklist if you have changed something on the Backend or Frontend:

  • Tested the feature and it's working on a current and clean install.
  • Tested the main App features and they are still working on a current and clean install. (Login, Install, Play, Uninstall, Move games, etc.)
  • Created / Updated Tests (If necessary)
  • Created / Updated documentation (If necessary)

@CommandMC CommandMC requested review from a team, arielj, flavioislima, Etaash-mathamsetty, Nocccer and imLinguin and removed request for a team July 3, 2024 19:17
@CommandMC CommandMC self-assigned this Jul 3, 2024
@CommandMC CommandMC added the pr:ready-for-review Feature-complete, ready for the grind! :P label Jul 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr:ready-for-review Feature-complete, ready for the grind! :P
Projects
None yet
1 participant