Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix UI bugs in search bar #3854

Merged
merged 2 commits into from
Jul 11, 2024
Merged

Conversation

TabulateJarl8
Copy link
Contributor

While using Heroic, I noticed two small UI bugs (or what I believe to be bugs).

  1. The "x" button to clear the search bar didn't set the cursor to a pointer on hover, so I added that.
  2. The autocomplete dropdown underneath the search bar would still be present when there were no results, which looked kind of strange. Here's before and after photos of this:

image
image

Let me know if anything needs to be changed, but I thought I'd just do this really quick in case it was something you guys could benefit from. Thanks!


Use the following Checklist if you have changed something on the Backend or Frontend:

  • Tested the feature and it's working on a current and clean install.
  • Tested the main App features and they are still working on a current and clean install. (Login, Install, Play, Uninstall, Move games, etc.)
  • Created / Updated Tests (If necessary)
  • Created / Updated documentation (If necessary)

@flavioislima
Copy link
Member

flavioislima commented Jul 7, 2024

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

@TabulateJarl8
Copy link
Contributor Author

I have read the CLA Document and I hereby sign the CLA

@imLinguin imLinguin added the pr:ready-to-merge This PR is fully ready for merge. label Jul 8, 2024
@arielj arielj merged commit 00ce6fd into Heroic-Games-Launcher:main Jul 11, 2024
9 checks passed
@Heroic-Games-Launcher Heroic-Games-Launcher locked and limited conversation to collaborators Jul 11, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
pr:ready-to-merge This PR is fully ready for merge.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants