Model card creation #181
Merged
Model card creation #181
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rsion of 3.10 are included
annmary-roy
approved these changes
Jul 17, 2024
server/app/get_data.py
Outdated
| modelName = df['name'].tolist()[0] | ||
| if modelName == "": | ||
| return model_data_df, model_exe_df, model_input_df, model_output_df | ||
| else: |
There was a problem hiding this comment.
why two return statements here ?
server/app/get_data.py
Outdated
| return model_data_df, model_exe_df, model_input_df, model_output_df | ||
|
|
||
| # model's own data | ||
| model_data_df = query.get_artifact(modelName) |
There was a problem hiding this comment.
why two calls ..we should have got all this in the first call
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issues / Pull Requests
List all related issues and/or pull requests if there are any.
Description
Include a brief summary of the proposed changes.
What changes are proposed in this pull request?
examples in this repository need to be updated too).
Checklist:
uses Google-style formatting and any other formatting that is supported by mkdocs and plugins this project
uses.