-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dataslice and StepMetrics: artifact and metadata pull and push related changes #189
Conversation
cmflib/cmf.py
Outdated
@@ -132,6 +132,7 @@ def __init__( | |||
config.sqlite.filename_uri = filepath | |||
self.store = metadata_store.MetadataStore(config) | |||
self.filepath = filepath | |||
self.dataslice_path = None | |||
self.child_context = None |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why dataslice path is a cmf object property ?. One cmf object can have multiple executions and for each execution this path is different . So it is not safe to put it there
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
removed
Related Issues / Pull Requests
List all related issues and/or pull requests if there are any.
Description
Include a brief summary of the proposed changes.
What changes are proposed in this pull request?
examples in this repository need to be updated too).
Checklist:
uses Google-style formatting and any other formatting that is supported by mkdocs and plugins this project
uses.