Skip to content
This repository has been archived by the owner on Oct 15, 2020. It is now read-only.

#288 Add query string to force extract_bundle #289

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

#288 Add query string to force extract_bundle #289

wants to merge 1 commit into from

Conversation

joannelynch92
Copy link

@joannelynch92 joannelynch92 commented Jul 27, 2017

Description

extract_bundle hangs when a pop up appears on the GUI. This query string will force the call through

Issues Resolved

Possible solution for #288

Check List

  • New functionality includes testing.
    • All tests pass for Python 2.7+ & 3.4+($ tox).
  • New functionality has been documented in the README if applicable.
    • New functionality has been thoroughly documented in the examples (please include helpful comments).
  • Changes are documented in the CHANGELOG.

@tmiotto
Copy link
Contributor

tmiotto commented Jul 27, 2017

Great @joannelynch92

We really appreciate you want to contribute to the SDK.

Regarding the code, we need a more SDK-like approach, the way you implemented is only showing in an example how to inject the uri with the force flag.

I suggest you taking a look at Storage System's get_reachable_ports and remove

AnushaY1916 pushed a commit that referenced this pull request Mar 2, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants