This repository has been archived by the owner on Oct 15, 2020. It is now read-only.
Allow connection reuse #361
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eamonnotoole
force-pushed
the
reuse-connection
branch
4 times, most recently
from
e5b7026
to
0b81ebe
Compare
|
Can we add this flag-reuse_connection in the sample config file i.e examples/config-rename.json as well? |
|
Thanks Priyanka - change to examples/config-rename.json added |
|
@soodpr I'm having difficulty pushing up the change - networking issues on our side - so I'll try again tomorrow AM (my time) when hopefully the problems will be resolved. |
eamonnotoole
force-pushed
the
reuse-connection
branch
from
0b81ebe
to
b6a0c18
Compare
|
@soodpr Change pushed up. |
eamonnotoole
force-pushed
the
reuse-connection
branch
from
b6a0c18
to
2460972
Compare
eamonnotoole
force-pushed
the
reuse-connection
branch
from
2460972
to
20f9253
Compare
We have to use the SDK in environments where the total number of connections is restricted, where repeatedly opening and closing connections can cause instability, and with fairly large latencies in opening a new connection. To aid stability and SDK performance in these environments we allow for the reuse of https connections as returned by get_connection(). Connections will be reused when 'reuse_connection' is set to True or when the ONEVIEWSDK_REUSE_CONNECTION is anything other than an empty string. We've added a unit-test for this new capability.
eamonnotoole
force-pushed
the
reuse-connection
branch
from
20f9253
to
e81474d
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have to use the SDK in environments were the total number of
connections is restricted, where repeatedly opening and closing
connections can cause instability, and with fairly large latencies in
opening a new connection. To aid stability and SDK performance in these
environments we allow for the reuse of https connections as returned by
get_connection(). Connections will be reused when 'reuse_connection' is
set to True or when the ONEVIEWSDK_REUSE_CONNECTION is anything other
than an empty string. We've added a unit-test for this new capability.
Description
[Describe what this change achieves]
Issues Resolved
[List any issues this PR will resolve. e.g., Fixes #1]
Check List
$ tox).