This repository has been archived by the owner on Oct 15, 2020. It is now read-only.
Upgrade/500 600/id pools #390
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jyothisgm
requested review from
sijeesh,
dileepds,
madhav-bharadwaj,
soodpr and
Sowmyahsg
soodpr
reviewed
Aug 23, 2018
examples/id_pools.py
Outdated
| @@ -45,56 +45,48 @@ | |||
| pool_type_ipv4 = 'ipv4' | |||
|
|
|||
| print("\n Gets the Pool: " + pool_type_vsn) | |||
| id_pool = oneview_client.id_pools.get(pool_type_vsn) | |||
| pprint(id_pool) | |||
| id_pool_1 = oneview_client.id_pools.get_by_name(pool_type_vsn) | |||
There was a problem hiding this comment.
can you please give more relevant variable names like id_pool_ipv4 and so on...
soodpr
reviewed
Aug 23, 2018
| @@ -522,9 +520,7 @@ def id_pools(self): | |||
| Returns: | |||
| IdPools: | |||
| """ | |||
| if not self.__id_pools: | |||
There was a problem hiding this comment.
i think we have to remove these references from the constructor as well
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
ID Pool support for V500 and V600 and support generic classs
Check List
$ tox).