This repository has been archived by the owner on Oct 15, 2020. It is now read-only.
Firmware bundle #392
Open
Firmware bundle #392
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
madhav-bharadwaj
requested review from
soodpr,
dileepds,
jyothisgm,
Sowmyahsg and
sijeesh
soodpr
reviewed
Aug 24, 2018
CHANGELOG.md
Outdated
| @@ -1,4 +1,10 @@ | |||
| # 4.7.1 | |||
| # 4.7.1 (Unreleased) | |||
There was a problem hiding this comment.
Lets mark this release as 5.0 as it will be a major change because of design changes
soodpr
reviewed
Aug 24, 2018
| @@ -1209,7 +1209,7 @@ def create(self, resource, uri=None, timeout=-1, custom_headers=None, default_va | |||
|
|
|||
| return self.__do_post(uri, resource, timeout, custom_headers) | |||
|
|
|||
| def upload(self, file_path, uri=None, timeout=-1): | |||
| def upload(self, file_path, uri=None, timeout=-1, custom_headers=None): | |||
There was a problem hiding this comment.
Add documentation for the new arg in the comments section
soodpr
reviewed
Aug 24, 2018
| @@ -45,7 +45,7 @@ def __init__(self, con): | |||
| self._connection = con | |||
| self._client = ResourceClient(con, self.URI) | |||
|
|
|||
| def upload(self, file_path, timeout=-1): | |||
| def upload(self, file_path, timeout=-1, custom_headers=None,): | |||
There was a problem hiding this comment.
remove comma in the end of args list and add documentation
soodpr
reviewed
Aug 24, 2018
hpOneView/connection.py
Outdated
| @@ -283,7 +283,7 @@ def post_multipart_with_response_handling(self, uri, file_path, baseName): | |||
|
|
|||
| return None, body | |||
|
|
|||
| def post_multipart(self, uri, fields, files, baseName, verbose=False): | |||
| def post_multipart(self, uri, fields, files, baseName, custom_headers, verbose=False): | |||
There was a problem hiding this comment.
again custom_headers should be added in the end of args list as we discussed and is custom_headers a mandatory param. If not, then better to give default value
|
What's the progress of this? |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds additional custom headers' support for firmware bundles introduced in api600.
Check List
$ tox).