Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update.sh: tweak tag handling. #1060

Merged
merged 1 commit into from
Sep 21, 2016
Merged

update.sh: tweak tag handling. #1060

merged 1 commit into from
Sep 21, 2016

Conversation

MikeMcQuaid
Copy link
Member

@MikeMcQuaid MikeMcQuaid commented Sep 21, 2016

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew tests with your changes locally?

  • Don't let the UPSTREAM_TAG variable bleed into future repository checks.
  • Even if the tag branch is an ancestor of the tag ensure that it's forced back to the tag anyway.

This will go into 1.0.1 but I'll hold off for a bit until we get any user reports (should only affect Homebrew developers and even then it's kinda tricky to reproduce).

Fixes #1062.

- Don't let the `UPSTREAM_TAG` variable bleed into future repository
  checks.
- Even if the tag branch is an ancestor of the tag ensure that it's
  forced back to the tag anyway.
@MikeMcQuaid MikeMcQuaid added this to the 1.0.1 milestone Sep 21, 2016
@MikeMcQuaid
Copy link
Member Author

First report in #998 (comment). Figuring out whether they had "developer mode" enabled.

@MikeMcQuaid MikeMcQuaid merged commit a381b59 into Homebrew:master Sep 21, 2016
@MikeMcQuaid MikeMcQuaid deleted the update-tag-tweaks branch September 21, 2016 14:54
@Homebrew Homebrew locked and limited conversation to collaborators May 3, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant