Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix coverage reporting. #1089

Merged
merged 1 commit into from
Sep 23, 2016
Merged

Fix coverage reporting. #1089

merged 1 commit into from
Sep 23, 2016

Conversation

reitermarkus
Copy link
Member

@reitermarkus reitermarkus commented Sep 22, 2016 •
edited
Loading

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew tests with your changes locally?

This should make coverage reports more credible.

@alyssais alyssais mentioned this pull request Sep 23, 2016
Merged
5 tasks
MikeMcQuaid
MikeMcQuaid approved these changes Sep 23, 2016
View reviewed changes
Copy link
Member

@MikeMcQuaid MikeMcQuaid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work 👍

@reitermarkus
Copy link
Member Author

Coverage is 63.26%, seems about right. 😄

@reitermarkus reitermarkus merged commit 759ee58 into Homebrew:master Sep 23, 2016
@reitermarkus reitermarkus deleted the coverage branch September 23, 2016 08:35
@Homebrew Homebrew locked and limited conversation to collaborators May 3, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@MikeMcQuaid MikeMcQuaid MikeMcQuaid approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@reitermarkus @MikeMcQuaid