Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix exit code for multilingual cask audit. #1216

Merged
merged 1 commit into from
Oct 6, 2016

Conversation

reitermarkus
Copy link
Member

@reitermarkus reitermarkus commented Oct 3, 2016

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew tests with your changes locally?

Previously brew cask audit would exit with 0, even if some of the languages failed.

@Homebrew/cask

@reitermarkus
Copy link
Member Author

@jawshooah or @vitorgalvao, also please review (and approve) this.

@reitermarkus reitermarkus merged commit faebc64 into Homebrew:master Oct 6, 2016
@reitermarkus reitermarkus removed the in progress Maintainers are working on this label Oct 6, 2016
@reitermarkus reitermarkus deleted the fix-language-audit branch October 6, 2016 13:51
@Homebrew Homebrew locked and limited conversation to collaborators May 3, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants