Don't choke on invalid UTF-8 in file output
#1298
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sometimes `file` output contains data from the file under examination, which may include binary data that does not represent valid UTF-8 codepoints. String#split dies if it doesn't understand the encoding, so tell Ruby to treat `file` output as a bytestring.
|
cc @jawshooah |
|
A failing line looks like: |
jawshooah
previously requested changes
Oct 16, 2016
| path, info = line.split("\0") | ||
| next unless info.to_s.include?("text") | ||
| path, info = line.split("\0", 2) | ||
| next unless info.include?("text") |
There was a problem hiding this comment.
The to_s needs to stay for the reasons given in #1273 (comment).
There was a problem hiding this comment.
oh, gross, okay! this is surprising enough i think being more explicit about it is good
MikeMcQuaid
approved these changes
Oct 16, 2016
jawshooah
approved these changes
Oct 16, 2016
|
Thanks for the reviews! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sometimes
fileoutput contains data from the file under examination,which may include binary data that does not represent valid UTF-8
codepoints. String#split dies if it doesn't understand the encoding, so
tell Ruby to treat
fileoutput as a bytestring.