Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tweak 'brew deps' zsh completions #1306

Merged
merged 1 commit into from
Oct 17, 2016

Conversation

apjanke
Copy link
Contributor

@apjanke apjanke commented Oct 17, 2016

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew tests with your changes locally?

This tweaks the zsh completions for brew deps.

  • Fixes a couple typos
  • Removes reference to "dependents" from description, since only dependencies are displayed (dependents are displayed by brew uses)
  • Harmonize description text for --installed to reduce redundant display
  • Note the two-behavior nature of --installed when used with regular formula display
  • Add description for --tree
  • Reflect that --tree does not respect --include-* or --skip-recommended

@apjanke apjanke added the in progress Maintainers are working on this label Oct 17, 2016
@apjanke apjanke changed the title tweak zsh 'brew deps' completions tweak 'brew deps' zsh completions Oct 17, 2016
@apjanke apjanke force-pushed the tweak-brew-deps-zsh-completion branch from b849652 to b7fc819 Compare October 17, 2016 04:15
@MikeMcQuaid
Copy link
Member

Great work. Crazy long-term stretch-goal: generate completions from --help output.

@MikeMcQuaid MikeMcQuaid merged commit 0296439 into Homebrew:master Oct 17, 2016
@MikeMcQuaid MikeMcQuaid removed the in progress Maintainers are working on this label Oct 17, 2016
@apjanke apjanke deleted the tweak-brew-deps-zsh-completion branch October 17, 2016 07:44
@apjanke
Copy link
Contributor Author

apjanke commented Oct 17, 2016

Thanks!

Crazy long-term stretch-goal: generate completions from --help output.

Too crazy for me, I think. Given the interactions between options (e.g. if --foo is present, do not suggest completion of --bar or this other set of options...) you'd need to embed equivalent metadata in a variant --help output. Or switch to a programmatic option definition, and generate both the --help and the completions from it. Or something. :)

@Homebrew Homebrew locked and limited conversation to collaborators May 3, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants