Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update-report: default Caskroom moved to prefix. #1445

Merged
merged 1 commit into from
Nov 5, 2016
Merged

update-report: default Caskroom moved to prefix. #1445

merged 1 commit into from
Nov 5, 2016

Conversation

MikeMcQuaid
Copy link
Member

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew tests with your changes locally?

Look at HOMEBREW_PREFIX rather than HOMEBREW_REPOSITORY for the default Caskroom location. CC @jawshooah @reitermarkus to check I've got this correct.

@MikeMcQuaid
update-report: default Caskroom moved to prefix.
276864e 
Look at HOMEBREW_PREFIX rather than HOMEBREW_REPOSITORY for the default
Caskroom location.
@MikeMcQuaid MikeMcQuaid added the in progress Maintainers are working on this label Nov 5, 2016
jawshooah
jawshooah approved these changes Nov 5, 2016
View reviewed changes
Copy link
Contributor

@jawshooah jawshooah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@reitermarkus reitermarkus merged commit 654fa25 into Homebrew:master Nov 5, 2016
@reitermarkus reitermarkus removed the in progress Maintainers are working on this label Nov 5, 2016
@MikeMcQuaid MikeMcQuaid deleted the caskroom-prefix branch November 11, 2016 13:18
@Homebrew Homebrew locked and limited conversation to collaborators May 3, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@reitermarkus reitermarkus reitermarkus approved these changes

@jawshooah jawshooah jawshooah approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@MikeMcQuaid @reitermarkus @jawshooah