Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tap tests: sort tap names for comparison #1463

Merged
merged 1 commit into from
Nov 9, 2016

Conversation

mistydemeo
Copy link
Member

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew tests with your changes locally?

Since the directories returned by filesystem operations aren't necessarily in alphabetical order, this could fail in really pedantic ways:

 10) Failure:
TapTest#test_names [/home/vagrant/.linuxbrew/Library/Homebrew/test/test_tap.rb:108]:
--- expected
+++ actual
@@ -1 +1 @@
-["homebrew/core", "homebrew/foo"]
+["homebrew/foo", "homebrew/core"]

@BrewTestBot BrewTestBot added the in progress Maintainers are working on this label Nov 8, 2016
@MikeMcQuaid MikeMcQuaid merged commit a7dc9e1 into Homebrew:master Nov 9, 2016
@MikeMcQuaid
Copy link
Member

Makes sense, thanks @mistydemeo!

@MikeMcQuaid MikeMcQuaid removed the in progress Maintainers are working on this label Nov 9, 2016
@mistydemeo mistydemeo deleted the test_tap_fix branch November 9, 2016 16:54
@Homebrew Homebrew locked and limited conversation to collaborators May 3, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants