Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

brew.rb: don't exit when failing to set devcmdrun. #1466

Merged
merged 1 commit into from
Nov 10, 2016
Merged

brew.rb: don't exit when failing to set devcmdrun. #1466

merged 1 commit into from
Nov 10, 2016

Conversation

MikeMcQuaid
Copy link
Member

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew tests with your changes locally?

It's not necessary to make this a hard failure so don't (and this makes it more consistent with brew.sh).

CC @vszakats

Fixes #1462.

It's not necessary to make this a hard failure so don't (and this makes
it more consistent with `brew.sh`).

Fixes #1462.
@MikeMcQuaid MikeMcQuaid added the in progress Maintainers are working on this label Nov 9, 2016
@MikeMcQuaid MikeMcQuaid merged commit 9889007 into Homebrew:master Nov 10, 2016
@MikeMcQuaid MikeMcQuaid deleted the brew-rb-no-devcmdrun-fail branch November 10, 2016 16:29
@MikeMcQuaid MikeMcQuaid removed the in progress Maintainers are working on this label Nov 10, 2016
@Homebrew Homebrew locked and limited conversation to collaborators May 3, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant