Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Hbc::Locations in tests. #1475

Merged
merged 2 commits into from
Nov 11, 2016
Merged

Conversation

reitermarkus
Copy link
Member

@reitermarkus reitermarkus commented Nov 10, 2016

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew tests with your changes locally?

This should fix the 100+ errors caused by unintentional usage of Hbc.legacy_caskroom during tests as can be seen in #1473.


@Homebrew/cask

@reitermarkus reitermarkus added in progress Maintainers are working on this cask Homebrew Cask labels Nov 10, 2016
@reitermarkus reitermarkus merged commit 8241bbb into Homebrew:master Nov 11, 2016
@reitermarkus reitermarkus deleted the fix-locations branch November 11, 2016 12:43
@reitermarkus reitermarkus removed the in progress Maintainers are working on this label Nov 11, 2016
@Homebrew Homebrew locked and limited conversation to collaborators May 3, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cask Homebrew Cask
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants