add brew analytics command

[xu-cheng]

No description provided.

[MikeMcQuaid]

Looks great to me. Mind updating https://github.com/Homebrew/brew/blob/master/share/doc/homebrew/Analytics.md to note to use it instead of the commands?

[MikeMcQuaid]

Would be good to point to the analytics documentation in here and use the language from there (anonymous user behaviour analytics)

[xu-cheng]

done

[DomT4]

Heh, was talking about this with Mike the other day. You beat me to actually getting the work done 😃.

[UniqMartin]

This should be

#:  * `analytics` (`on`|`off`):

to be consistent with other documentation we have where there's a list of mandatory alternatives.

[xu-cheng]

done.

[DomT4]

Part of me wonders if HOMEBREW_NO_ANALYTICS_THIS_RUN shouldn't be set permanently for this command. It seems a little counterproductive to track anonymous usage at the same time someone is considering whether to stay opted in/out.

[UniqMartin]

Good work! It would be great to also update the shell completion of your shell to work with this new command.

Part of me wonders if HOMEBREW_NO_ANALYTICS_THIS_RUN shouldn't be set permanently for this command. It seems a little counterproductive to track anonymous usage at the same time someone is considering whether to stay opted in/out.

We could consider adding it to the list of commands exempt from tracking (we're already excluding brew commands).

[DomT4]

Your suggestion sounds good to me, FWIW.

Edit - Reworded for clarity.

[xu-cheng]

Part of me wonders if HOMEBREW_NO_ANALYTICS_THIS_RUN shouldn't be set permanently for this command. It seems a little counterproductive to track anonymous usage at the same time someone is considering whether to stay opted in/out.

We could consider adding it to the list of commands exempt from tracking (we're already excluding brew commands).

I think we should do this in another PR. Because there are many other commands (e.g, --prefix) belong to this category. At the same time, I'm wondering should we only send screen view for only selective commands as personally I don't feel that such statistics can help us much.

Addressed other comments.

[MikeMcQuaid]

Currently brew analytics off will be tracked and create the UUID file, no? Also missing the change to the analytics documentation.

[xu-cheng]

Currently brew analytics off will be tracked and create the UUID file, no?

Good point, fixed this.

Also missing the change to the analytics documentation.

What do you mean? Isn't it already in there? https://github.com/Homebrew/brew/pull/173/files#diff-de62681d221dc414a999cf7eec2f0f36

[MikeMcQuaid]

@xu-cheng Sorry, I missed that before, my mistake.

[xu-cheng]

NP, just want to check if I missing anything.

Ready to ship?

[UniqMartin]

Minor nit, but so far we seem to prefer either

case "$HOMEBREW_COMMAND" in
  --prefix|analytics|command|commands)
    return
    ;;
esac

or

case "$HOMEBREW_COMMAND" in
  --prefix|analytics|command|commands) return;;
esac

[UniqMartin]

Ready to ship?

One final (and very minor) remark, but otherwise 👍.