-
-
Notifications
You must be signed in to change notification settings - Fork 9.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
superenv: port to generic OS. #457
Conversation
I know the benefits outweigh the costs here, but all this refactoring for cross-platform compatibility makes it a complete nightmare to quickly gather a full picture in terms of what calling |
@@ -13,7 +13,7 @@ def sh | |||
ENV.activate_extensions! | |||
|
|||
if superenv? | |||
ENV.x11 = MacOS::X11.installed? | |||
ENV.x11_if_installed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you explain what this was/is supposed to do? I don't really understand this, but I'm not sure the replacement is equivalent.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Set ENV.x11
if MacOS::X11.installed?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I find this massively confusing, also when compared to what x11
means in stdenv
. But oh well, I guess legacy …
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Open to better suggestions. Have a generic_sh
method?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure. I never used brew sh
and I'm not entirely sure what that line is supposed to do (in more broader terms, I understood your explanation from above).
You might want to give brew graph-require --start=extend/ENV/super | dot -Tpdf > super.pdf
open super.pdf Graph for
This would involve touching JavaScript, something I'm not considering just yet. :eek: |
brew tests
with your changes locally?More work towards making Homebrew/brew a cross-platform core for e.g. Linuxbrew and Tigerbrew too.