ENV/scm/git: only execute file

[xu-cheng]

Fixes #491.

[MikeMcQuaid]

👍

[UniqMartin]

Thanks for the quick fix! One of the less intuitive features of *NIX that a check for an executable file needs to be executable? && !directory? … I've probably made this mistake more than once.

[xu-cheng]

@UniqMartin You mean I should use executable? && !directory? instead of executable? && file?? May I ask what is the difference?

Also you should take a look at #496

[UniqMartin]

You mean I should use executable? && !directory? instead of executable? && file?? May I ask what is the difference?

No, executable? && file? should be equally fine (or even preferable). I had already forgotten what you used in the code when I wrote my comment. Sorry for possibly causing confusion!

Also you should take a look at #496

Eventually I will, but I'm a bit short on time at the moment and I'm still in the process of working my way through my backlog of GitHub notifications …