Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pull: use homebrew remote if HOMEBREW_FORCE_HOMEBREW_ON_LINUX #7070

Merged
merged 2 commits into from
Feb 24, 2020

Conversation

dawidd6
Copy link
Member

@dawidd6 dawidd6 commented Feb 22, 2020

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew tests with your changes locally?

With this change, linux maintainers are able to perform brew pull --bottle after exporting HOMEBREW_FORCE_HOMEBREW_ON_LINUX environment variable and checking out the master branch of homebrew remote.

Successful commit example: Homebrew/homebrew-core@76bbb1d

Bottle works (thanks to @issyl0 for this):

╭─issyl0@chi /usr/local/Homebrew/Library/Taps/homebrew/homebrew-core ‹master*› 
╰─ $ brew install findomain 
==> Downloading https://homebrew.bintray.com/bottles/findomain-1.4.1.catalina.bottle.tar.gz
==> Downloading from https://akamai.bintray.com/6f/6fb58677ebe4f07259ecb13fd99fd33f0615e299b33bd795cc1265c9e8b87a3b?__gda__=exp=1582402268~hmac=e1456e4284f4033f93611c72076d2be705ce12990172f67f51397b654765bd4
######################################################################## 100.0%
==> Pouring findomain-1.4.1.catalina.bottle.tar.gz
:beer:  /usr/local/Cellar/findomain/1.4.1: 6 files, 4.4MB
╭─issyl0@chi /usr/local/Homebrew/Library/Taps/homebrew/homebrew-core ‹master*› 
╰─ $ brew test findomain                                                                                                                                                                                   1 ↵
Testing findomain
==> /usr/local/Cellar/findomain/1.4.1/bin/findomain -t brew.sh

@request-info
Copy link

request-info bot commented Feb 22, 2020

Please provide a better issue/pull request title and/or description!

@request-info request-info bot added the needs response Needs a response from the issue/PR author label Feb 22, 2020
@issyl0
Copy link
Member

issyl0 commented Feb 22, 2020

This is truly life changing. Doesn't stop me wanting a Mac again tho. 😂

@issyl0 issyl0 removed the needs response Needs a response from the issue/PR author label Feb 22, 2020
@MikeMcQuaid MikeMcQuaid merged commit 670227b into Homebrew:master Feb 24, 2020
@MikeMcQuaid
Copy link
Member

Thanks again @dawidd6!

@dawidd6 dawidd6 deleted the pull-on-linux branch February 24, 2020 17:27
@lock lock bot added the outdated PR was locked due to age label Mar 27, 2020
@lock lock bot locked as resolved and limited conversation to collaborators Mar 27, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
outdated PR was locked due to age
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants