Enable ruby-macho by default.

[woodruffw]

• Have you followed the guidelines in our Contributing document?
• Have you checked to ensure there aren't other open Pull Requests for the same change?
• Have you added an explanation of what your changes do and why you'd like us to include them?
• Have you written new tests for your changes? Here's an example.
• Have you successfully run brew tests with your changes locally?

---

Flips HOMEBREW_RUBY_MACHO to HOMEBREW_NO_RUBY_MACHO.

I also deleted the HOMEBREW_RUBY_MACHO enablement line in test-bot, since this PR enables it by default (and no longer checks that variable).

[MikeMcQuaid]

HOMEBREW_NO_RUBY_MACHO

In what situation(s) would one set that? I'm wondering if it's worth just deleting the existing code now?

[woodruffw]

In what situation(s) would one set that? I'm wondering if it's worth just deleting the existing code now?

In the unlikely event that we run into any bugs immediately after rolling this out, we could tell people to set HOMEBREW_NO_RUBY_MACHO as a quick fix.

I discussed this with @UniqMartin in a PM on slack, and 2-3 weeks seems like a good rollout period to us. If nothing substantial happens after that, we can simply delete the cctools-based implementation and the environment checks associated with it.

[MikeMcQuaid]

I discussed this with @UniqMartin in a PM on slack, and 2-3 weeks seems like a good rollout period to us. If nothing substantial happens after that, we can simply delete the cctools-based implementation and the environment checks associated with it.

👍 seems like a good plan to me.

[UniqMartin]

HOMEBREW_NO_RUBY_MACHO

In what situation(s) would one set that? I'm wondering if it's worth just deleting the existing code now?

As already mentioned by @woodruffw, that's a temporary measure suggested by me.

The other motivation is to ship this feature and thus formally finalize William's GSoC project (with the stated goal of enabling the code for all Homebrew users) with a minimal PR that can be shipped more quickly than a thorough cleanup. (But we definitely aim for a proper cleanup.)

[MikeMcQuaid]

Hooray 👏

[UniqMartin]

Thanks @woodruffw; great work! 🎉 And sorry for the delay …

[woodruffw]

No problem! Glad to 🚢 this out!

[MikeMcQuaid]

@woodruffw @UniqMartin can definitely 💀 the old code now I think!

[woodruffw]

Got it! I'll have a PR ready in a few 😄