Adding minishift-unstable for minishift 1.0.0-beta.1 #3046
Conversation
| name 'Minishift' | ||
| homepage 'https://github.com/minishift/minishift' | ||
|
|
||
| depends_on arch: :x86_64 |
There was a problem hiding this comment.
hi @vitorgalvao do you mean the name and homepage stuff is useless?
| homepage 'https://github.com/minishift/minishift' | ||
|
|
||
| depends_on arch: :x86_64 | ||
| depends_on formula: 'unar' |
There was a problem hiding this comment.
I'll remove the arch and depends_on stuff, agreed it's not needed.
|
|
||
| depends_on arch: :x86_64 | ||
| depends_on formula: 'unar' | ||
| container type: :tar |
There was a problem hiding this comment.
Unlikely this is necessary.
There was a problem hiding this comment.
just tested it, as you pointed out this isn't needed so will remove it.
| sha256 '2d4020615bd86b814c678fedbf6072488101c26298a90fb081904c6913d88497' | ||
|
|
||
| url "https://github.com/minishift/minishift/releases/download/v#{version}/minishift-#{version}-darwin-amd64.tgz" | ||
| appcast 'https://github.com/minishift/minishift/releases.atom', checkpoint: 'f78e6fe63a0e0f8f3cae4f97daebe8528e8a38a7d023c6630598b128ee6c8fed' |
There was a problem hiding this comment.
checkpoint needs to be on another line.
There was a problem hiding this comment.
great, will fix this.
|
Hi @vitorgalvao thanks for the code review - I've made the changes you requested. I've left in the |
What do you mean with “for now”? Those are mandatory. |
|
Awesome, thanks for the help! |
A homebrew cask already exists for
minishifthowever we also needed a version for the latest unstable version, hence this pull request to addminishift-unstableto homebrew cask versions.After making all changes to the cask:
brew cask audit --download minishift-unstableis error-free.brew cask style --fix minishift-unstablereports no offenses.Additionally, if adding a new cask:
brew cask install {{cask_file}}worked successfully.brew cask uninstall {{cask_file}}worked successfully.