-
-
Notifications
You must be signed in to change notification settings - Fork 10.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Creality Slicer v4.8.2-96 #116881
Add Creality Slicer v4.8.2-96 #116881
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for your contribution to homebrew-cask
@vahrennd! My review is in the code. Take it with a grain of salt as I am not a maintainer.
@vahrennd I am assuming that you need access to a Creality FDM 3D printer for this software to be useful? If so, this needs to be submitted to the |
You would need access to a 3D printer to make much use of it, sure. It technically has preset profiles for other brands of printers as well as the ability to define your own. ultimaker-cura is basically an equivalent piece of software available in homebrew-cask which is what made me think it belonged here. Would it help if I updated the description to more accurately reflect that? I mostly just took that from their download page. |
Thanks for the explanation -- I think actually it will be fine in this repository. |
Important: Do not tick a checkbox if you haven’t performed its action. Honesty is indispensable for a smooth review process.
In the following questions
<cask>
is the token of the cask you're submitting.After making all changes to a cask, verify:
brew audit --cask <cask>
is error-free.brew style --fix <cask>
reports no offenses.Additionally, if adding a new cask:
brew audit --new-cask <cask>
worked successfully.brew install --cask <cask>
worked successfully.brew uninstall --cask <cask>
worked successfully.