Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Creality Slicer v4.8.2-96 #116881

Merged
merged 5 commits into from
Jan 4, 2022
Merged

Conversation

vahrennd
Copy link
Contributor

@vahrennd vahrennd commented Jan 3, 2022

Important: Do not tick a checkbox if you haven’t performed its action. Honesty is indispensable for a smooth review process.

In the following questions <cask> is the token of the cask you're submitting.

After making all changes to a cask, verify:

Additionally, if adding a new cask:

  • Named the cask according to the token reference.
  • Checked the cask was not already refused.
  • Checked the cask is submitted to the correct repo.
  • brew audit --new-cask <cask> worked successfully.
  • brew install --cask <cask> worked successfully.
  • brew uninstall --cask <cask> worked successfully.

Copy link
Contributor

@neutric neutric left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution to homebrew-cask @vahrennd! My review is in the code. Take it with a grain of salt as I am not a maintainer.

Casks/creality-slicer.rb Show resolved Hide resolved
Casks/creality-slicer.rb Outdated Show resolved Hide resolved
Casks/creality-slicer.rb Show resolved Hide resolved
Casks/creality-slicer.rb Show resolved Hide resolved
@miccal
Copy link
Member

miccal commented Jan 4, 2022

@vahrennd I am assuming that you need access to a Creality FDM 3D printer for this software to be useful?

If so, this needs to be submitted to the homebrew-cask-drivers repository.

@miccal miccal added the awaiting user reply Issue needs response from a user. label Jan 4, 2022
@vahrennd
Copy link
Contributor Author

vahrennd commented Jan 4, 2022

You would need access to a 3D printer to make much use of it, sure. It technically has preset profiles for other brands of printers as well as the ability to define your own. ultimaker-cura is basically an equivalent piece of software available in homebrew-cask which is what made me think it belonged here.

Would it help if I updated the description to more accurately reflect that? I mostly just took that from their download page.

@miccal
Copy link
Member

miccal commented Jan 4, 2022

You would need access to a 3D printer to make much use of it, sure. It technically has preset profiles for other brands of printers as well as the ability to define your own. ultimaker-cura is basically an equivalent piece of software available in homebrew-cask which is what made me think it belonged here.

Would it help if I updated the description to more accurately reflect that? I mostly just took that from their download page.

Thanks for the explanation -- I think actually it will be fine in this repository.

@miccal miccal removed the awaiting user reply Issue needs response from a user. label Jan 4, 2022
@miccal miccal merged commit 3d76c7e into Homebrew:master Jan 4, 2022
@vahrennd vahrennd deleted the creality-slicer branch January 4, 2022 03:38
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 5, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants