recc 1.2.21 #191819
recc 1.2.21 #191819
Conversation
github-actions
bot
added
the
new formula
|
Thanks for contributing to Homebrew! 🎉 It looks like you're having trouble with a CI failure. See our contribution guide for help. You may be most interested in the section on dealing with CI failures. You can find the CI logs in the Checks tab of your pull request. |
github-actions
bot
added
the
autosquash
github-actions
bot
added
autosquash
github-actions
bot
added
autosquash
github-actions
bot
removed
the
autosquash
github-actions
bot
added
the
autosquash
sakeeb
force-pushed
the
recc
branch
2 times, most recently
from
bd370df
to
699e2df
Compare
github-actions
bot
added
automerge-skip
|
@carlocab, thank you for your detailed review. It really helped to trim down a lot of unnecessary content. I have addressed all the review comments. I included caveat about usage that is specific to installation using Homebrew formula. I noticed a similar caveat is used for ccache. |
github-actions
bot
added
long build
github-actions
bot
removed
the
automerge-skip
github-actions
bot
added
automerge-skip
|
@sakeeb Please |
github-actions
bot
removed
automerge-skip
Rebased and squashed |
Formula/r/recc.rb
Outdated
| (bin/"recc-#{compiler}").write <<~EOS | ||
| #!/usr/bin/env sh | ||
|
|
||
| #{bin}/recc $(command -v #{compiler}) "$@" |
There was a problem hiding this comment.
Is there any scope to upstream some/all of these helpers scripts?
There was a problem hiding this comment.
It makes sense to add the recc-${compiler} script. I'll also revisit our previous discussion on defining some default values for those included in recc.conf.
If there are no major concerns, would it be acceptable to merge the formula in the meantime?
There was a problem hiding this comment.
If there are no major concerns, would it be acceptable to merge the formula in the meantime?
I'm afraid this is a fairly major concern to me given how much actual runtime code (not just building the software) is being shipped in this formula. It's the bulk of this formula file and this is unusual in Homebrew.
What's your relationship with upstream? Are you a user/contributor/maintainer?
Would it be tenable to ship a first version of this formulae with no compiler/server helper scripts and an upstream configuration file instead?
There was a problem hiding this comment.
I am one of the upstream maintainers. I would prefer to ship it in an out-of-the-box working state. I will move the PR to a draft state and revisit it after adding the necessary configuration and helper scripts upstream.
There was a problem hiding this comment.
Thanks! Appreciate your patience and hard work here ❤️
There was a problem hiding this comment.
As discussed, I added the wrappers in upstream project and updated the formula to use them
github-actions
bot
added
automerge-skip
github-actions
bot
added
new formula
github-actions
bot
added
the
automerge-skip
RECC is a compiler launcher that caches the results on compilation and link command, and optionally forward them to a remote execution service. Remove running launchctrl command in caveat Update Formula/r/recc.rb Co-authored-by: Carlo Cabrera <30379873+carlocab@users.noreply.github.com> Update Formula/r/recc.rb Co-authored-by: Carlo Cabrera <30379873+carlocab@users.noreply.github.com> Update Formula/r/recc.rb Co-authored-by: Carlo Cabrera <30379873+carlocab@users.noreply.github.com> Update Formula/r/recc.rb Co-authored-by: Carlo Cabrera <30379873+carlocab@users.noreply.github.com> recc 1.2.21 Address review comments recc 1.2.21 tests Added tests to start recc-server and run recc-cc command twice. The second run should result in a cache hit. Update test case Update test Update Formula/r/recc.rb Co-authored-by: Carlo Cabrera <30379873+carlocab@users.noreply.github.com> Update Formula/r/recc.rb Co-authored-by: Carlo Cabrera <30379873+carlocab@users.noreply.github.com> Update Formula/r/recc.rb Co-authored-by: Carlo Cabrera <30379873+carlocab@users.noreply.github.com> Update Formula/r/recc.rb Co-authored-by: Carlo Cabrera <30379873+carlocab@users.noreply.github.com> Update Formula/r/recc.rb Co-authored-by: Carlo Cabrera <30379873+carlocab@users.noreply.github.com> Update Formula/r/recc.rb Co-authored-by: Carlo Cabrera <30379873+carlocab@users.noreply.github.com> Update Formula/r/recc.rb Co-authored-by: Carlo Cabrera <30379873+carlocab@users.noreply.github.com> recc 1.2.21: Update user configuration location Use etc as location for system wide recc.conf location. In the absense of the etc/recc.conf, a default configuration installed in prefix/etc/recc/recc.conf will be used. recc 1.2.21 Add caveat about how to invoke compiler using recc. The instructions in caveat is specific to how homebrew is configured Update Formula/r/recc.rb Co-authored-by: Carlo Cabrera <30379873+carlocab@users.noreply.github.com> Update Formula/r/recc.rb Co-authored-by: Carlo Cabrera <30379873+carlocab@users.noreply.github.com> Update Formula/r/recc.rb Co-authored-by: Carlo Cabrera <30379873+carlocab@users.noreply.github.com> Update Formula/r/recc.rb Co-authored-by: Carlo Cabrera <30379873+carlocab@users.noreply.github.com> Update Formula/r/recc.rb Co-authored-by: Carlo Cabrera <30379873+carlocab@users.noreply.github.com> recc 1.2.24 Update version Use wrapper scripts from the upstream project
github-actions
bot
removed
the
automerge-skip
|
Dropped the merge commit, this should now be ready for review again |
RECC is a compiler launcher that caches the results on compilation and link command, and optionally forward them to a remote execution service.
HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>, where<formula>is the name of the formula you're submitting?brew test <formula>, where<formula>is the name of the formula you're submitting?brew audit --strict <formula>(after doingHOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>)? If this is a new formula, does it passbrew audit --new <formula>?