Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[libccd] Use correct option for double precision #28434

Closed
wants to merge 2 commits into from

Conversation

jslee02
Copy link
Contributor

@jslee02 jslee02 commented May 29, 2018

  • Have you followed the guidelines for contributing?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing brew install <formula>)?

The libccd version in this formulae is v2.0, and the correct option for double precision is -DCCD_DOUBLE=ON. -DENABLE_DOUBLE_PRECISION=ON is for the master branch, which is not released yet. (see: flexible-collision-library/fcl#291 (comment))

cc @scpeters

@scpeters
Copy link
Member

Thanks @jslee02 ! This will fix that fcl issue. My only question is whether it will cause an issue for the ode formula, which depends on this and defaults to single precision.

@scpeters
Copy link
Member

The CI is happy (brew linkage ode, brew test ode), so maybe ODE will be just fine after all.

@SeanCurtis-TRI
Copy link

SeanCurtis-TRI commented Jun 8, 2018

How do we get this merged?

@stale
Copy link

stale bot commented Jun 29, 2018

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

@stale stale bot added the stale No recent activity label Jun 29, 2018
@SeanCurtis-TRI
Copy link

Someone needs to merge this if stale bot is complaining.

@stale stale bot removed the stale No recent activity label Jun 29, 2018
@ilovezfs
Copy link
Contributor

Thanks again @jslee02!

@ilovezfs
Copy link
Contributor

@BrewTestBot test this please

@ilovezfs
Copy link
Contributor

Shipped! 🚀

@ilovezfs ilovezfs closed this in 92925ac Jun 29, 2018
@jslee02 jslee02 deleted the patch-5 branch June 30, 2018 06:21
jslee02 added a commit to jslee02/homebrew-core that referenced this pull request Jul 1, 2018
due to recent update of libccd (Homebrew#28434)
@lock lock bot added the outdated PR was locked due to age label Jul 30, 2018
@lock lock bot locked as resolved and limited conversation to collaborators Jul 30, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
outdated PR was locked due to age
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants