Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate airshare to python@3.9 #62208

Closed
wants to merge 1 commit into from
Closed

Migrate airshare to python@3.9 #62208

wants to merge 1 commit into from

Conversation

fxcoudert
Copy link
Member

@fxcoudert fxcoudert commented Oct 6, 2020 •
edited
Loading

First try of a script to migrate formulas to python 3.9

@request-info
Copy link

request-info bot commented Oct 6, 2020

Please provide a better issue/pull request title and/or description!

@request-info request-info bot added the needs response Needs a response from the issue/PR author label Oct 6, 2020
@BrewTestBot BrewTestBot added python Python use is a significant feature of the PR or issue and removed needs response Needs a response from the issue/PR author labels Oct 6, 2020
@fxcoudert fxcoudert changed the title Migrate to python@3.9 Migrate airshare to python@3.9 Oct 6, 2020
@Rylan12
Copy link
Member

Rylan12 commented Oct 6, 2020 

==> python3.9 -s /private/tmp/airshare--homebrew-virtualenv-20201006-28967-iy8m9f/target/bin/virtualenv -p python3.9 /usr/local/Cellar/airshare/0.1.6_1/libexec
Already using interpreter /usr/local/opt/python@3.9/bin/python3.9
Using base prefix '/usr/local/Cellar/python@3.9/3.9.0/Frameworks/Python.framework/Versions/3.9'
New python executable in /usr/local/Cellar/airshare/0.1.6_1/libexec/bin/python3.9
Also creating executable in /usr/local/Cellar/airshare/0.1.6_1/libexec/bin/python
ERROR: The executable /usr/local/Cellar/airshare/0.1.6_1/libexec/bin/python3.9 is not functioning
ERROR: It thinks sys.prefix is '/usr/local/Cellar/python@3.9/3.9.0/Frameworks/Python.framework/Versions/3.9' (should be '/usr/local/Cellar/airshare/0.1.6_1/libexec')
ERROR: virtualenv is not compatible with this system or executable

So it looks like virtualenv 16.4.7 is not compatible with Python 3.9. I've checked locally, virtualenv 16.4.10 (the latest version that's below 20.0.0) doesn't work either.

We may need to update the homebrew-virtualenv resource to 20.0.33. It was briefly discussed here: Homebrew/brew#8379 (comment)

@fxcoudert
Copy link
Member Author

I'm re-running CI, to check the virtualenv fix at Homebrew/brew#8873
Even if CI is green, this should not be merged before the next Brew tag ships, expected on Monday 2020-10-12.

@fxcoudert
Copy link
Member Author

Test failed on 10.15 only, probably a network fluke or certificate issue:

ConnectionRefusedError: [Errno 61] Connection refused

@BrewTestBot
Copy link
Member

:shipit: @fxcoudert has triggered a merge.

@BrewTestBot
Copy link
Member

⚠️ @fxcoudert bottle publish failed.

@fxcoudert
Copy link
Member Author

I tried re-running the tests, but it's giving tons of unrelated audits:
GitHub patches should end with .patch, not .diff

@dtrodrigues dtrodrigues mentioned this pull request Oct 23, 2020
Closed
@BrewTestBot
Copy link
Member

:shipit: @fxcoudert has triggered a merge.

@fxcoudert fxcoudert deleted the py39_airshare branch October 23, 2020 13:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
python Python use is a significant feature of the PR or issue python-3.9-migration
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@fxcoudert @Rylan12 @BrewTestBot