-
-
Notifications
You must be signed in to change notification settings - Fork 11.4k
Conversation
Travis CI has its own copy of Homebrew. And I think it would be best if we can run test on the clone copy. At the other hand, we need to test formula with prefix of
|
@xu-cheng Yep, need to work that out. I'm wondering if there's a way to coax Travis into checking out into a certain directory. |
Another thing I just found is Travis CI supports custom log folding. We can use it to fold log inside brew test-bot. Refs: |
@xu-cheng Great idea. |
- osx_image: beta-xcode6.2 # 10.9 | ||
|
||
rvm: | ||
- rvm use system |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should be just:
rvm:
- system
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yep.
@xu-cheng Looks like this is green now. Thoughts on merging? |
puts "travis_time:start:#{@travis_timer_id}" | ||
puts cmd_line | ||
return | ||
end |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A style nit, I would prefer if else
then if return
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I prefer early return
😉
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I usually use early return
in nested or complex conditions. To me, using it in simple binary conditions makes the code imbalance or asymmetric. Anyway, your call.
Just testing Travis for our main PRs.