Skip to content
This repository has been archived by the owner on Jul 4, 2023. It is now read-only.

[WIP] Add Travis CI configuration. #43976

Closed
wants to merge 2 commits into from
Closed

[WIP] Add Travis CI configuration. #43976

wants to merge 2 commits into from

Conversation

MikeMcQuaid
Copy link
Member

Just testing Travis for our main PRs.

@xu-cheng
Copy link
Member

Travis CI has its own copy of Homebrew. And I think it would be best if we can run test on the clone copy. At the other hand, we need to test formula with prefix of /user/local. Therefore, can or should we do something like this:

rm /usr/local/bin/brew
ln -sf $PWD/bin/brew /usr/local/bin/brew
mkdir -p /usr/local/Cellar

@MikeMcQuaid
Copy link
Member Author

@xu-cheng Yep, need to work that out. I'm wondering if there's a way to coax Travis into checking out into a certain directory.

@xu-cheng
Copy link
Member

Another thing I just found is Travis CI supports custom log folding. We can use it to fold log inside brew test-bot. Refs:

@MikeMcQuaid
Copy link
Member Author

@xu-cheng Great idea.

- osx_image: beta-xcode6.2 # 10.9

rvm:
- rvm use system
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be just:

rvm: 
   - system

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep.

@MikeMcQuaid
Copy link
Member Author

@xu-cheng Looks like this is green now. Thoughts on merging?

puts "travis_time:start:#{@travis_timer_id}"
puts cmd_line
return
end
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A style nit, I would prefer if else then if return.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I prefer early return 😉

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I usually use early return in nested or complex conditions. To me, using it in simple binary conditions makes the code imbalance or asymmetric. Anyway, your call.

@MikeMcQuaid MikeMcQuaid deleted the travis-ci branch September 18, 2015 08:59
@Homebrew Homebrew locked and limited conversation to collaborators Jul 10, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants