travis: avoid polluting path with Ruby 1.8 on 10.9 #47694
Conversation
Particularly the `bundler` Gem requires the right Ruby binary to be in the PATH to work correctly if the Ruby binary used to run Homebrew is overridden via `HOMEBREW_RUBY_PATH` and thus intentionally not prefixed to the PATH (as that would affect formulae with a Ruby dependency). The workaround here is to prefix this path only when a Gem is activated via `Homebrew.install_gem_setup_path!` (currently used in `brew man`, `brew style`, and `brew tests`).
Putting the Ruby 1.8 we use to run tests on 10.9 into the PATH adversely affects formulae with a Ruby dependency (possibly other formulae, too). Remove this hack, as it is no longer needed.
|
👍 |
|
LGTM 👍 Another possible option for Travis/Jenkins (which this PR would help) would be to install Ruby to a non- |
This PR is complementary to your suggestion and makes it possible to use any Ruby to run the Homebrew code without having to put this Ruby into To make this really work in all scenarios, we ideally need a Ruby that is either completely independent of Homebrew or one that is sufficiently independent from all other formulae, i.e. has all its dependencies vendored in some way, so neither depends on other formulae nor functions as a dependency for other formulae. For efficiency reasons, we might want to strip down this Ruby as much as possible (i.e. no headers, no documentation, no bells and whistles), so we can basically just download an archive, unpack it, and then we're ready to go. (Effectively a Homebrew/homebrew-versions#1097 on steroids.) |
Putting the Ruby 1.8 we use to run tests on 10.9 into the PATH adversely affects formulae with a Ruby dependency (possibly other formulae, too). Remove this hack, as it is no longer needed.