#235 - Removed unused method #241
Conversation
| /** | ||
| * Create a new builder. | ||
| * | ||
| * @return a new builder | ||
| */ | ||
| public static Builder newHttpClientBuilder(BackendService backendService) { | ||
| return new Builder(backendService); | ||
| public static Builder newHttpClientBuilder(Id applicationId) { |
There was a problem hiding this comment.
I think we should call the parameter backendServiceId for consistency.
|
|
||
| public Builder(BackendService backendService) { | ||
| this.backendService = checkNotNull(backendService); | ||
| public Builder(Id applicationId) { |
There was a problem hiding this comment.
I think we should call the parameter and field backendServiceId for consistency.
VivianLopes
force-pushed
the
issue_235_remove_unused_method
branch
from
4a64f5a
to
9f58868
Compare
| public Builder(BackendService backendService) { | ||
| this.backendService = checkNotNull(backendService); | ||
| public Builder(Id backendServiceId) { | ||
| this.backendServiceId = checkNotNull(backendServiceId); |
There was a problem hiding this comment.
Please use Java 8's requireNonNull instead of Guava's checkNotNull. Same comment for stickySessionConfig(...)
components/client/src/main/java/com/hotels/styx/client/StyxHttpClient.java
Show resolved
Hide resolved
VivianLopes
force-pushed
the
issue_235_remove_unused_method
branch
from
62e5322
to
29a2156
Compare
| val client = newHttpClientBuilder(backendService.id) | ||
| .loadBalancer(stickySessionStrategy(activeOrigins(backendService))) | ||
| .stickySessionConfig(stickySessionConfig) |
There was a problem hiding this comment.
It's not clear how to do this properly/generally in our case, but we might want to test that the required 'Builder' methods (in this case, stickySessionConfig() ) have been invoked in our UnitTests instead of only during the EndToEndTests . Ideally, we would guarantee this at compile time or at the very least at runtime.
This is a clear short-coming of our usage of the builder pattern, we cannot guarantee that the object has been constructed with all the required parameters...
Removed unused
isHttps()and removedBackendServiceconstructor argument fromStyxHttpClient.Builder