Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Typescript 4.5 support #299

Merged

Conversation

rmarscher
Copy link
Contributor

Potential fix for #298

Upgrade @babel/parser to support syntax added in typescript 4.5 which is used by the latest SvelteKit / language-tools.

I published this to npm @rmarscher/houdini@0.14.5-babel-parser.0 and confirmed it fixes the test project I created - rmarscher/sveltekit-houdini-typescript@a225207

Thanks!

@changeset-bot
Copy link

changeset-bot bot commented May 17, 2022

🦋 Changeset detected

Latest commit: fb66b5c

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@rmarscher rmarscher force-pushed the typescript-4-babel-parser-upgrade branch from 30115b1 to b7f618c Compare May 17, 2022 06:07
@rmarscher rmarscher force-pushed the typescript-4-babel-parser-upgrade branch from b7f618c to 6fb5a04 Compare May 17, 2022 06:11
@AlecAivazis
Copy link
Collaborator

Nice!! Thanks for fixing this. Sorry I didn’t get back to you sooner, I’ve been on vacation. This should be good to go once you add a change set (I can do it if you prefer).

@alexlafroscia
Copy link
Contributor

I ran into the same problem and was able to confirm that the parsing error I was seeing is solved by the fork that @rmarscher published to npm!

@AlecAivazis
Copy link
Collaborator

Thank you for confirming @alexlafroscia! Now that I’m home I’ll get this merged and published asap

@AlecAivazis
Copy link
Collaborator

I went ahead and added a changeset. will merge this once we get the 👍 from github

@AlecAivazis AlecAivazis enabled auto-merge (squash) May 25, 2022 00:41
@AlecAivazis AlecAivazis merged commit 83032d8 into HoudiniGraphql:main May 25, 2022
@github-actions github-actions bot mentioned this pull request May 25, 2022
@rmarscher
Copy link
Contributor Author

Thanks a lot, @AlecAivazis . Sorry I missed adding a changeset.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants