Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pass all of server.js data from root layout #545

Merged
merged 2 commits into from
Sep 15, 2022
Merged

Conversation

AlecAivazis
Copy link
Collaborator

@AlecAivazis AlecAivazis commented Sep 15, 2022

Fixes #544

This PR fixes an issue introduced in #542 that hid the data returned from +layout.server.js

To help everyone out, please make sure your PR does the following:

  • Update the first line to point to the ticket that this PR fixes
  • Add a message that clearly describes the fix
  • If applicable, add a test that would fail without this fix
    • this is tricky because we also want a test that we are able to fake the file if it doesn't exist. I'm opting to leave things how they are now since the changes are pretty clear
  • Make sure the unit and integration tests pass locally with pnpm run tests and cd integration && pnpm run tests
  • Includes a changeset if your fix affects the user with pnpm changeset

@vercel
Copy link

vercel bot commented Sep 15, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
docs ✅ Ready (Inspect) Visit Preview Sep 15, 2022 at 5:25PM (UTC)
docs-next ✅ Ready (Inspect) Visit Preview Sep 15, 2022 at 5:25PM (UTC)

@changeset-bot
Copy link

changeset-bot bot commented Sep 15, 2022

🦋 Changeset detected

Latest commit: 335aaf2

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Houdini 0.16.2 breaks +layout.server.ts
1 participant