Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Component query types #610

Merged
merged 9 commits into from
Oct 19, 2022
Merged

Component query types #610

merged 9 commits into from
Oct 19, 2022

Conversation

AlecAivazis
Copy link
Collaborator

@AlecAivazis AlecAivazis commented Oct 18, 2022

Fixes #603

This PR generates types for non-route components in the same type root (ie, users will use the same ./$houdini relative import)

Unfortunately, since the implementation relies on glob, it's not as easy to test as the rest of our file system interactions. I spent a little time thinking through writing our own but I'd like to avoid that if possible.

cc @endigma

To help everyone out, please make sure your PR does the following:

  • Update the first line to point to the ticket that this PR fixes
  • Add a message that clearly describes the fix
  • If applicable, add a test that would fail without this fix
  • Make sure the unit and integration tests pass locally with pnpm run tests and cd integration && pnpm run tests
  • Includes a changeset if your fix affects the user with pnpm changeset

@changeset-bot
Copy link

changeset-bot bot commented Oct 18, 2022

🦋 Changeset detected

Latest commit: 646e0c7

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
houdini-svelte Patch
houdini Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel
Copy link

vercel bot commented Oct 18, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
docs-next ✅ Ready (Inspect) Visit Preview Oct 19, 2022 at 2:52AM (UTC)

@AlecAivazis AlecAivazis merged commit 3168f7d into main Oct 19, 2022
@AlecAivazis AlecAivazis deleted the component-query-types branch October 19, 2022 02:56
This was referenced Oct 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Component query variable function types
1 participant