Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ NEW: global stores - no query stores by default #852

Merged
merged 14 commits into from
Jan 31, 2023

Conversation

jycouet
Copy link
Contributor

@jycouet jycouet commented Jan 26, 2023

New config: storesToGenerate in houdini-plugin-svelte-global-stores plugin.
By default, query stores will not be generated, you can opt-in by config

To help everyone out, please make sure your PR does the following:

  • Update the first line to point to the ticket that this PR fixes
  • Add a message that clearly describes the fix
  • If applicable, add a test that would fail without this fix
  • Make sure the unit and integration tests pass locally with pnpm run tests and cd integration && pnpm run tests
  • Includes a changeset if your fix affects the user with pnpm changeset

@changeset-bot
Copy link

changeset-bot bot commented Jan 26, 2023

🦋 Changeset detected

Latest commit: 1c8343d

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 4 packages
Name Type
houdini-plugin-svelte-global-stores Major
houdini-react Major
houdini-svelte Major
houdini Major

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel
Copy link

vercel bot commented Jan 26, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated
docs ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Jan 30, 2023 at 11:58PM (UTC)
docs-next ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Jan 30, 2023 at 11:58PM (UTC)

.changeset/poor-hats-notice.md Outdated Show resolved Hide resolved
e2e/sveltekit/houdini.config.js Outdated Show resolved Hide resolved
@AlecAivazis AlecAivazis deleted the feat/global-stores-noQuery branch January 31, 2023 00:02
AlecAivazis added a commit that referenced this pull request Feb 10, 2023
* ✨ NEW: global stores no query

* 👌 FIX: lint

* ♻️ UPDATE: lock

* ⚡ UPDATE: to major

* 🚸 IMPROVE: api

* ✅ NEW: tests

* 🐛 FIX: casing

* 🐛 FIX: last chapter of a page is now searchable

* 👌 UPDATE: lint

* 👌 FIX: yoga error

* rename storesToGenerate to generate

* fix tests

---------

Co-authored-by: Alec Aivazis <alec@aivazis.com>
AlecAivazis added a commit that referenced this pull request Feb 10, 2023
* ✨ NEW: global stores no query

* 👌 FIX: lint

* ♻️ UPDATE: lock

* ⚡ UPDATE: to major

* 🚸 IMPROVE: api

* ✅ NEW: tests

* 🐛 FIX: casing

* 🐛 FIX: last chapter of a page is now searchable

* 👌 UPDATE: lint

* 👌 FIX: yoga error

* rename storesToGenerate to generate

* fix tests

---------

Co-authored-by: Alec Aivazis <alec@aivazis.com>
@AlecAivazis AlecAivazis mentioned this pull request Feb 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants