document last core-js changes, remove HtmxOneNineTenScriptPreProcesso…

…r because default parameters are now supported by core-js
HtmlUnit · Sep 22, 2024 · 08bfc11 · 08bfc11
1 parent 152560e
commit 08bfc11
Show file tree

Hide file tree

Showing 6 changed files with 14 additions and 98 deletions.
diff --git a/src/changes/changes.xml b/src/changes/changes.xml
@@ -8,6 +8,19 @@
 
     <body>
         <release version="4.5.0" date="xxxx, 2024" description="Chrome/Edge 128, Firefox 129, WebWorker, Bugfixes">
+            <action type="remove" dev="rbri">
+                Class org.htmlunit.javascript.preprocessor.HtmxOneNineTenScriptPreProcessor removed.
+                This class is no longer required because default parameter support was added to core-js.
+            </action>
+            <action type="add" dev="RhinoTeam">
+                core-js: Support for default parameters added.
+            </action>
+            <action type="add" dev="RhinoTeam">
+                core-js: String.isWellFormed() and String.toWellFormed() added.
+            </action>
+            <action type="add" dev="RhinoTeam">
+                core-js: Support surrogate chars in JSON.stringify().
+            </action>
             <action type="update" dev="rbri">
                 Upgrade Apache commons-io to 2.17.0.
             </action>

diff --git a/src/main/java/org/htmlunit/javascript/preprocessor/HtmxOneNineTenScriptPreProcessor.java b/src/main/java/org/htmlunit/javascript/preprocessor/HtmxOneNineTenScriptPreProcessor.java
diff --git a/src/test/java/org/htmlunit/libraries/HtmxTest1x9x10.java b/src/test/java/org/htmlunit/libraries/HtmxTest1x9x10.java
@@ -15,7 +15,6 @@
 package org.htmlunit.libraries;
 
 import org.htmlunit.WebClient;
-import org.htmlunit.javascript.preprocessor.HtmxOneNineTenScriptPreProcessor;
 import org.htmlunit.junit.BrowserRunner;
 import org.htmlunit.junit.BrowserRunner.Alerts;
 import org.htmlunit.junit.BrowserRunner.BuggyWebDriver;
@@ -44,7 +43,7 @@ public void htmx() throws Exception {
     protected void setupWebClient(final WebClient webClient) {
         super.setupWebClient(webClient);
 
-        webClient.setScriptPreProcessor(new HtmxOneNineTenScriptPreProcessor());
+        // there is a script error in sse.js (line 32)
         webClient.getOptions().setThrowExceptionOnScriptError(false);
     }
 }
diff --git a/src/test/java/org/htmlunit/libraries/HtmxTest1x9x12.java b/src/test/java/org/htmlunit/libraries/HtmxTest1x9x12.java
@@ -14,8 +14,6 @@
  */
 package org.htmlunit.libraries;
 
-import org.htmlunit.WebClient;
-import org.htmlunit.javascript.preprocessor.HtmxOneNineTenScriptPreProcessor;
 import org.htmlunit.junit.BrowserRunner;
 import org.htmlunit.junit.BrowserRunner.Alerts;
 import org.htmlunit.junit.BrowserRunner.BuggyWebDriver;
@@ -39,11 +37,4 @@ public class HtmxTest1x9x12 extends HtmxTest {
     public void htmx() throws Exception {
         htmx("htmx-1.9.12");
     }
-
-    @Override
-    protected void setupWebClient(final WebClient webClient) {
-        super.setupWebClient(webClient);
-
-        webClient.setScriptPreProcessor(new HtmxOneNineTenScriptPreProcessor());
-    }
 }
diff --git a/src/test/java/org/htmlunit/libraries/HtmxTest2x0x0.java b/src/test/java/org/htmlunit/libraries/HtmxTest2x0x0.java
@@ -14,8 +14,6 @@
  */
 package org.htmlunit.libraries;
 
-import org.htmlunit.WebClient;
-import org.htmlunit.javascript.preprocessor.HtmxOneNineTenScriptPreProcessor;
 import org.htmlunit.junit.BrowserRunner;
 import org.htmlunit.junit.BrowserRunner.Alerts;
 import org.htmlunit.junit.BrowserRunner.HtmlUnitNYI;
@@ -43,11 +41,4 @@ public class HtmxTest2x0x0 extends HtmxTest {
     public void htmx() throws Exception {
         htmx("htmx-2.0.0");
     }
-
-    @Override
-    protected void setupWebClient(final WebClient webClient) {
-        super.setupWebClient(webClient);
-
-        webClient.setScriptPreProcessor(new HtmxOneNineTenScriptPreProcessor());
-    }
 }
diff --git a/src/test/java/org/htmlunit/libraries/HtmxTest2x0x2.java b/src/test/java/org/htmlunit/libraries/HtmxTest2x0x2.java
@@ -14,8 +14,6 @@
  */
 package org.htmlunit.libraries;
 
-import org.htmlunit.WebClient;
-import org.htmlunit.javascript.preprocessor.HtmxOneNineTenScriptPreProcessor;
 import org.htmlunit.junit.BrowserRunner;
 import org.htmlunit.junit.BrowserRunner.Alerts;
 import org.htmlunit.junit.BrowserRunner.HtmlUnitNYI;
@@ -43,11 +41,4 @@ public class HtmxTest2x0x2 extends HtmxTest {
     public void htmx() throws Exception {
         htmx("htmx-2.0.2");
     }
-
-    @Override
-    protected void setupWebClient(final WebClient webClient) {
-        super.setupWebClient(webClient);
-
-        webClient.setScriptPreProcessor(new HtmxOneNineTenScriptPreProcessor());
-    }
 }