Skip to content

Commit

Permalink
Firefox 131, FirefoxESR 128
Browse files Browse the repository at this point in the history
  • Loading branch information
rbri committed Oct 14, 2024
1 parent 0ab3b01 commit 861d988
Show file tree
Hide file tree
Showing 4 changed files with 4 additions and 16 deletions.
4 changes: 0 additions & 4 deletions src/main/java/org/htmlunit/BrowserVersionFeatures.java
Original file line number Diff line number Diff line change
Expand Up @@ -156,10 +156,6 @@ public enum BrowserVersionFeatures {
@BrowserFeature({CHROME, EDGE})
HTMLIMAGE_NAME_VALUE_PARAMS,

/** When clicking a {@code checkbox} or {@code radio} input the surrounding anchor is not clicked. */
@BrowserFeature({CHROME, EDGE, FF})
HTMLINPUT_CHECKBOX_DOES_NOT_CLICK_SURROUNDING_ANCHOR,

/** HTMLInputElement image type is not supported. */
@BrowserFeature({CHROME, EDGE})
HTMLINPUT_TYPE_IMAGE_IGNORES_CUSTOM_VALIDITY,
Expand Down
5 changes: 1 addition & 4 deletions src/main/java/org/htmlunit/html/HtmlCheckBoxInput.java
Original file line number Diff line number Diff line change
Expand Up @@ -14,8 +14,6 @@
*/
package org.htmlunit.html;

import static org.htmlunit.BrowserVersionFeatures.HTMLINPUT_CHECKBOX_DOES_NOT_CLICK_SURROUNDING_ANCHOR;

import java.io.IOException;
import java.util.Map;

Expand Down Expand Up @@ -208,8 +206,7 @@ protected void setAttributeNS(final String namespaceURI, final String qualifiedN
*/
@Override
protected boolean propagateClickStateUpdateToParent() {
return !hasFeature(HTMLINPUT_CHECKBOX_DOES_NOT_CLICK_SURROUNDING_ANCHOR)
&& super.propagateClickStateUpdateToParent();
return false;
}

@Override
Expand Down
5 changes: 1 addition & 4 deletions src/main/java/org/htmlunit/html/HtmlRadioButtonInput.java
Original file line number Diff line number Diff line change
Expand Up @@ -14,8 +14,6 @@
*/
package org.htmlunit.html;

import static org.htmlunit.BrowserVersionFeatures.HTMLINPUT_CHECKBOX_DOES_NOT_CLICK_SURROUNDING_ANCHOR;

import java.io.IOException;
import java.util.Map;

Expand Down Expand Up @@ -279,8 +277,7 @@ protected void setAttributeNS(final String namespaceURI, final String qualifiedN
*/
@Override
protected boolean propagateClickStateUpdateToParent() {
return !hasFeature(HTMLINPUT_CHECKBOX_DOES_NOT_CLICK_SURROUNDING_ANCHOR)
&& super.propagateClickStateUpdateToParent();
return false;
}

@Override
Expand Down
6 changes: 2 additions & 4 deletions src/test/java/org/htmlunit/html/HtmlAnchorTest.java
Original file line number Diff line number Diff line change
Expand Up @@ -152,8 +152,7 @@ public void clickNestedButtonElement() throws Exception {
* @throws Exception if an error occurs
*/
@Test
@Alerts(DEFAULT = "",
FF_ESR = "page2.html")
@Alerts("")
public void clickNestedCheckboxElement() throws Exception {
final String html =
"<html>\n"
Expand Down Expand Up @@ -298,8 +297,7 @@ public void clickNestedOptionElement() throws Exception {
* @throws Exception if an error occurs
*/
@Test
@Alerts(DEFAULT = "",
FF_ESR = "page2.html")
@Alerts("")
public void clickNestedRadioElement() throws Exception {
final String html =
"<html>\n"
Expand Down

0 comments on commit 861d988

Please sign in to comment.