-
Notifications
You must be signed in to change notification settings - Fork 2.2k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
feat: LEAP-883: Custom Scripts (#5879)
- add `idAttr` parameter into `View` tag to make easier to work with custom styles and so on - add `lsfInit` and `beforeLsfDestroy` events into data manager for better control of the life cycle ### PR fulfills these requirements - [x] Commit message(s) and PR title follows the format `[fix|feat|ci|chore|doc]: TICKET-ID: Short description of change made` ex. `fix: DEV-XXXX: Removed inconsistent code usage causing intermittent errors` - [ ] Tests for the changes have been added/updated (for bug fixes/features) - [ ] Docs have been added/updated (for bug fixes/features) - [x] Best efforts were made to ensure docs/code are concise and coherent (checked for spelling/grammatical errors, commented out code, debug logs etc.) - [x] Self-reviewed and ran all changes on a local instance (for bug fixes/features) #### Change has impacts in these area(s) - [ ] Product design - [ ] Backend (Database) - [ ] Backend (API) - [x] Frontend ### Does this PR introduce a breaking change? - [ ] Yes, and covered entirely by feature flag(s) - [ ] Yes, and covered partially by feature flag(s) - [x] No - [ ] Not sure (briefly explain the situation below) ### What level of testing was included in the change? - [ ] e2e - [ ] integration - [ ] unit ### Which logical domain(s) does this change affect? `DataManager`, `View` --------- Co-authored-by: robot-ci-heartex <robot-ci-heartex@users.noreply.github.com> Co-authored-by: hlomzik <hlomzik@users.noreply.github.com> Co-authored-by: hlomzik <hlomzik@gmail.com>
- Loading branch information
1 parent
d65a09a
commit 45082c7
Showing
14 changed files
with
70 additions
and
22 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,6 +1,6 @@ | ||
{ | ||
"message": "reordering resolutions", | ||
"commit": "f471a7ea61f3e0c75d3058015efe6b4e216011e3", | ||
"date": "2024-05-24T14:29:55.000Z", | ||
"branch": "fb-leap-913" | ||
"message": "Add beforeSaveAnnotation event into accepting and rejecting actions", | ||
"commit": "217f6c1a6faf3e7758c250fa74d98bc393109df9", | ||
"date": "2024-05-28T13:44:01.000Z", | ||
"branch": "fb-leap-883/custom-scripts" | ||
} |
Large diffs are not rendered by default.
Oops, something went wrong.
Large diffs are not rendered by default.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,6 +1,6 @@ | ||
{ | ||
"message": "reordering resolutions", | ||
"commit": "f471a7ea61f3e0c75d3058015efe6b4e216011e3", | ||
"date": "2024-05-24T14:29:55.000Z", | ||
"branch": "fb-leap-913" | ||
"message": "Add beforeSaveAnnotation event into accepting and rejecting actions", | ||
"commit": "217f6c1a6faf3e7758c250fa74d98bc393109df9", | ||
"date": "2024-05-28T13:44:01.000Z", | ||
"branch": "fb-leap-883/custom-scripts" | ||
} |
Large diffs are not rendered by default.
Oops, something went wrong.
Large diffs are not rendered by default.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,6 +1,6 @@ | ||
{ | ||
"message": "reordering resolutions", | ||
"commit": "f471a7ea61f3e0c75d3058015efe6b4e216011e3", | ||
"date": "2024-05-24T14:29:55.000Z", | ||
"branch": "fb-leap-913" | ||
"message": "Add beforeSaveAnnotation event into accepting and rejecting actions", | ||
"commit": "217f6c1a6faf3e7758c250fa74d98bc393109df9", | ||
"date": "2024-05-28T13:44:01.000Z", | ||
"branch": "fb-leap-883/custom-scripts" | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters