Skip to content

Commit

Permalink
fix: LSDV-1080: GCS expiration minutes value always comes back as 1 (#…
Browse files Browse the repository at this point in the history
…4111)

* fix: LSDV-1080: GCS expiration minutes value always comes back as 1

* ci: Build frontend

* it was backend after all

* ci: Build frontend

* reverting changes since this actually needs a different approach in the form

* fix the counter value prop

* ci: Build frontend

* ci: Build frontend

---------

Co-authored-by: robot-ci-heartex <robot-ci-heartex@users.noreply.github.com>
  • Loading branch information
bmartel and robot-ci-heartex committed May 3, 2023
1 parent 80a9830 commit bf99be5
Show file tree
Hide file tree
Showing 3 changed files with 4 additions and 2 deletions.
2 changes: 1 addition & 1 deletion label_studio/frontend/dist/react-app/index.js

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion label_studio/frontend/dist/react-app/index.js.map

Large diffs are not rendered by default.

2 changes: 2 additions & 0 deletions label_studio/frontend/src/components/Form/Form.js
Original file line number Diff line number Diff line change
Expand Up @@ -442,6 +442,8 @@ Form.Builder = React.forwardRef(({

if (['checkbox', 'radio', 'toggle'].includes(field.type)) {
commonProps.checked = getValue();
} else if (field.type === 'counter') {
commonProps.value = getValue();
} else {
commonProps.defaultValue = getValue();
}
Expand Down

2 comments on commit bf99be5

@Omer-ler
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hi,
I have just met this issue on my label-studio version 1.6.0rc5. is there anything I can do to fix it?
Thanks.

@Omer-ler
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SOLUTION: The newer version (1.8.0) got this issue solved (so we upgraded). Thanks anyway.

Please sign in to comment.