Skip to content

Commit

Permalink
fix: LSDV-5096: Loading a pre-signed url with the new proxy urls in a…
Browse files Browse the repository at this point in the history
… new tab does not work
  • Loading branch information
bmartel committed May 15, 2023
1 parent d37db11 commit feba3b3
Showing 1 changed file with 2 additions and 0 deletions.
2 changes: 2 additions & 0 deletions label_studio/core/static/js/sw.js
Original file line number Diff line number Diff line change
Expand Up @@ -50,6 +50,8 @@ async function handlePresignedUrl(event) {
if (
!event.request.url.startsWith(self.location.origin) ||
!event.request.url.includes(requestPathToCache) ||
// This is to avoid an error trying to load a direct presign URL in a new tab
event.request.url === self.location.href ||
// Easier to leave this uncached as if we were to handle this caching
// it would be more complex and not really worth the effort as it is not the most repeated
// request and it is not a big deal if it is not cached.
Expand Down

0 comments on commit feba3b3

Please sign in to comment.