Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: LSDV-1058: Data import missing file ids when multiple files uploaded async #3623

Merged
merged 5 commits into from
Jan 31, 2023

Conversation

bmartel
Copy link
Contributor

@bmartel bmartel commented Jan 30, 2023

PR fulfills these requirements

  • Commit message(s) and PR title follows the format [fix|feat|ci|chore|doc]: TICKET-ID: Short description of change made ex. fix: DEV-XXXX: Removed inconsistent code usage causing intermittent errors
  • Tests for the changes have been added/updated (for bug fixes/features)
  • Docs have been added/updated (for bug fixes/features)
  • Best efforts were made to ensure docs/code are concise and coherent (checked for spelling/grammatical errors, commented out code, debug logs etc.)
  • Self-reviewed and ran all changes on a local instance (for bug fixes/features)

Change has impacts in these area(s)

(check all that apply)

  • Product design
  • Backend (Database)
  • Backend (API)
  • Frontend

Describe the reason for change

When users were to upload multiple files consecutively while others were currently uploading, there was an issue where if some of the files resolved while there were still outstanding files uploading, clicking the "Import" button after all have resolved would only import the last files uploaded.

What does this fix?

Correctly handles all files and ids no matter the order or quantity. If uploading multiple of the same file, that will work correctly and generate separate tasks as expected on Import.

What libraries were added/updated?

N/A

Does this change affect performance?

No

Does this change affect security?

No

What alternative approaches were there?

N/A

What feature flags were used to cover this change?

N/A

Does this PR introduce a breaking change?

(check only one)

  • Yes, and covered entirely by feature flag(s)
  • Yes, and covered partially by feature flag(s)
  • No
  • Not sure (briefly explain the situation below)

What level of testing was included in the change?

(check all that apply)

  • e2e
  • integration
  • unit

Which logical domain(s) does this change affect?

Data Import

@bmartel
Copy link
Contributor Author

bmartel commented Jan 31, 2023

/git merge develop

Error: Merge conflict detected, please resolve it using the command line.

Workflow run

@bmartel bmartel marked this pull request as draft January 31, 2023 17:21
@bmartel bmartel marked this pull request as ready for review January 31, 2023 17:21
@bmartel bmartel merged commit 7a2d0f5 into develop Jan 31, 2023
@bmartel bmartel deleted the lsdv-1058 branch January 31, 2023 17:26
shayantabatabaee pushed a commit to shayantabatabaee/label-studio that referenced this pull request Sep 19, 2023
…aded async (HumanSignal#3623)

* fix: LSDV-1058: Data import missing file ids when multiple files uploaded async

* Update Import.js

* Build frontend

* Build frontend

---------

Co-authored-by: robot-ci-heartex <robot-ci-heartex@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants