fix: LSDV-4711: CORS error accessing previously annotated data #4091
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for heartex-docs canceled.
|
✅ Deploy Preview for label-studio-docs-new-theme canceled.
|
bmartel
changed the title
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## develop #4091 +/- ##
===========================================
+ Coverage 76.63% 76.68% +0.04%
===========================================
Files 155 155
Lines 11668 11669 +1
===========================================
+ Hits 8942 8948 +6
+ Misses 2726 2721 -5 see 4 files with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
Travis1282
approved these changes
Apr 24, 2023
Travis1282
pushed a commit
that referenced
this pull request
May 25, 2023
* fix: LSDV-4711: CORS error accessing previously annotated data * convert to tavern tests * reinstating the presign_storage_data test as it covers directly the functions * fix the resolving uri in the tests
shayantabatabaee
pushed a commit
to shayantabatabaee/label-studio
that referenced
this pull request
Sep 19, 2023
…Signal#4091) * fix: LSDV-4711: CORS error accessing previously annotated data * convert to tavern tests * reinstating the presign_storage_data test as it covers directly the functions * fix the resolving uri in the tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR fulfills these requirements
[fix|feat|ci|chore|doc]: TICKET-ID: Short description of change madeex.fix: DEV-XXXX: Removed inconsistent code usage causing intermittent errorsChange has impacts in these area(s)
(check all that apply)
Describe the reason for change
Follow up adjustments to fix some consistency issues, and a possible error return based on code review.
Does this PR introduce a breaking change?
(check only one)
What level of testing was included in the change?
(check all that apply)
Which logical domain(s) does this change affect?
Presigned Urls, CORS