fix: LSDV-4711: Presigned proxy redirect should not cache #4100
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for label-studio-docs-new-theme canceled.
|
✅ Deploy Preview for heartex-docs canceled.
|
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## develop #4100 +/- ##
========================================
Coverage 76.68% 76.68%
========================================
Files 155 155
Lines 11669 11671 +2
========================================
+ Hits 8948 8950 +2
Misses 2721 2721 ☔ View full report in Codecov by Sentry. |
makseq
approved these changes
Apr 26, 2023
bmartel
added a commit
that referenced
this pull request
Apr 26, 2023
bmartel
added a commit
that referenced
this pull request
Apr 26, 2023
Travis1282
pushed a commit
that referenced
this pull request
May 25, 2023
shayantabatabaee
pushed a commit
to shayantabatabaee/label-studio
that referenced
this pull request
Sep 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR fulfills these requirements
[fix|feat|ci|chore|doc]: TICKET-ID: Short description of change madeex.fix: DEV-XXXX: Removed inconsistent code usage causing intermittent errorsChange has impacts in these area(s)
(check all that apply)
Describe the reason for change
When testing locally with the python server directly, and the CORS fixes from #3991 it seems to cache a 303 redirect, which shouldn't be happening. So for now we will add a header to ensure the browser doesn't cache the redirects, until we have a more comprehensive solution ready.
Which logical domain(s) does this change affect?
Presigned URLS