Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: LSDV-5337: Pre-signed file proxy url clashing with already html encoded values causing errors in signature #4447

Merged
merged 7 commits into from
Jun 29, 2023
Merged

fix: LSDV-5337: Pre-signed file proxy url clashing with already html encoded values causing errors in signature #4447

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
f3b1424
fix: LSDV-5337: Pre-signed file proxy url clashing with already html …
bmartel Jun 26, 2023
7674368
Update base_models.py
bmartel Jun 26, 2023
2209f34
updating tests to account for change in assertions of url structure, …
bmartel Jun 27, 2023
ba643ab
Merge branch 'fb-lsdv-5337' of github.com:heartexlabs/label-studio in…
bmartel Jun 27, 2023
fd72156
Adding a test to outline resolution and support of the upper limits o…
bmartel Jun 27, 2023
3c67086
removing any vendor specifics, just keep the characters
bmartel Jun 27, 2023
2937dc6
don't need this in the stubs as it was triggering false positives on …
bmartel Jun 27, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
removing any vendor specifics, just keep the characters
  • Loading branch information
@bmartel
bmartel committed Jun 27, 2023
commit 3c6708614d59d24e826f183b17a9642523cb9adb
2 changes: 1 addition & 1 deletion label_studio/tests/tasks/test_presign_storage_data.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -173,7 +173,7 @@ def mock_task_get(*args, **kwargs):
# The total length of the fileuri can not be more than 1024 characters
# The length of the fileuri below is 1024 characters including the extension
longest_allowable_cloud_storage_path = "is/a/long/path/that/needs/to/be/1024/characters/long/so/that/it/gets/hashedis/a/long/path/that/needs/to/be/1024/characters/long/so/that/it/gets/hashedis/a/long/path/that/needs/to/be/1024/characters/long/so/that/it/gets/hashedis/a/long/path/that/needs/to/be/1024/characters/long/so/that/it/gets/hashedis/a/long/path/that/needs/to/be/1024/characters/long/so/that/it/gets/hashedis/a/long/path/that/needs/to/be/1024/characters/long/so/that/it/gets/hashedis/a/long/path/that/needs/to/be/1024/characters/long/so/that/it/gets/hashedis/a/long/path/that/needs/to/be/1024/characters/long/so/that/it/gets/hashedis/a/long/path/that/needs/to/be/1024/characters/long/so/that/it/gets/hashedis/a/long/path/that/needs/to/be/1024/characters/long/so/that/it/gets/hashedis/a/long/path/that/needs/to/be/1024/characters/long/so/that/it/gets/hashedis/a/long/path/that/needs/to/be/1024/characters/long/so/that/it/gets/hashedis/a/long/path/that/needs/to/be/1024/characters/long/so/that/it/gets/hashedis/long/path/that/needs/to/be/1024/characters.png"
longest_uri = f"azure-blob://{longest_allowable_cloud_storage_path}"
longest_uri = f"aaaaa-bbbb://{longest_allowable_cloud_storage_path}"

base64_encoded_uri = base64.urlsafe_b64encode(longest_uri.encode()).decode()

Expand Down
Loading