fix: LSDV-5071: Ensure secret key is securely set persisting a new one if required #4690
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for label-studio-docs-new-theme canceled.
|
✅ Deploy Preview for heartex-docs canceled.
|
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## develop #4690 +/- ##
===========================================
+ Coverage 75.83% 75.85% +0.02%
===========================================
Files 157 157
Lines 12522 12541 +19
===========================================
+ Hits 9496 9513 +17
- Misses 3026 3028 +2 ☔ View full report in Codecov by Sentry. |
wesleylima
reviewed
Aug 25, 2023
…directory location
jombooth
reviewed
Aug 25, 2023
jombooth
approved these changes
Aug 25, 2023
16 tasks
bmartel
added a commit
that referenced
this pull request
Aug 28, 2023
…e if required (#4690) * feat: retrieve SECRET_KEY from env with fallback * fix: LSDV-5071: Ensure secret key is securely set persisting a new one if required * use the ls data dir env if specified with a fallback to the standard directory location * add more context to warning message --------- Co-authored-by: Robert Schuh <github@eneticum.de>
bmartel
added a commit
that referenced
this pull request
Aug 28, 2023
…e if required (#4690) * feat: retrieve SECRET_KEY from env with fallback * fix: LSDV-5071: Ensure secret key is securely set persisting a new one if required * use the ls data dir env if specified with a fallback to the standard directory location * add more context to warning message --------- Co-authored-by: Robert Schuh <github@eneticum.de>
bmartel
added a commit
that referenced
this pull request
Aug 28, 2023
…the toggle, secure secret key (#4710) * [submodules] Build static HumanSignal/label-studio-frontend Workflow run: https://github.com/HumanSignal/label-studio/actions/runs/6005152608 * ci: Build frontend Workflow run: https://github.com/HumanSignal/label-studio/actions/runs/6005212377 * fix: LSDV-5071: Ensure secret key is securely set persisting a new one if required (#4690) * feat: retrieve SECRET_KEY from env with fallback * fix: LSDV-5071: Ensure secret key is securely set persisting a new one if required * use the ls data dir env if specified with a fallback to the standard directory location * add more context to warning message --------- Co-authored-by: Robert Schuh <github@eneticum.de> * [submodules] Build static HumanSignal/label-studio-frontend Workflow run: https://github.com/HumanSignal/label-studio/actions/runs/6005457685 --------- Co-authored-by: Travis Clark <travisjosephclark@gmail.com> Co-authored-by: robot-ci-heartex <robot-ci-heartex@users.noreply.github.com> Co-authored-by: bmartel <brandonmartel@gmail.com> Co-authored-by: Robert Schuh <github@eneticum.de>
shayantabatabaee
pushed a commit
to shayantabatabaee/label-studio
that referenced
this pull request
Sep 19, 2023
…e if required (HumanSignal#4690) * feat: retrieve SECRET_KEY from env with fallback * fix: LSDV-5071: Ensure secret key is securely set persisting a new one if required * use the ls data dir env if specified with a fallback to the standard directory location * add more context to warning message --------- Co-authored-by: Robert Schuh <github@eneticum.de>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR fulfills these requirements
[fix|feat|ci|chore|doc]: TICKET-ID: Short description of change madeex.fix: DEV-XXXX: Removed inconsistent code usage causing intermittent errorsChange has impacts in these area(s)
(check all that apply)