Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: OPTIC-45: Font styles incorrect on settings pages #5080

Merged
merged 2 commits into from
Nov 28, 2023
Merged

Conversation

bmartel
Copy link
Contributor

@bmartel bmartel commented Nov 23, 2023

PR fulfills these requirements

  • Commit message(s) and PR title follows the format [fix|feat|ci|chore|doc]: TICKET-ID: Short description of change made ex. fix: DEV-XXXX: Removed inconsistent code usage causing intermittent errors
  • Tests for the changes have been added/updated (for bug fixes/features)
  • Docs have been added/updated (for bug fixes/features)
  • Best efforts were made to ensure docs/code are concise and coherent (checked for spelling/grammatical errors, commented out code, debug logs etc.)
  • Self-reviewed and ran all changes on a local instance (for bug fixes/features)

Change has impacts in these area(s)

(check all that apply)

  • Product design
  • Backend (Database)
  • Backend (API)
  • Frontend

Describe the reason for change

Due to various used UI libraries and differing load orders throughout, in some pages Semantic UI library would overtake the default page font family. To combat this, the font-family is being set to Roboto with important, as this is the single font family in use within LabelStudio as curated by the design team and Semantic UI's reference to Lato should not take precedence anywhere in the application.

Does this PR introduce a breaking change?

(check only one)

  • Yes, and covered entirely by feature flag(s)
  • Yes, and covered partially by feature flag(s)
  • No
  • Not sure (briefly explain the situation below)

Copy link

netlify bot commented Nov 23, 2023

Deploy Preview for label-studio-docs-new-theme canceled.

Name Link
🔨 Latest commit 42fa252
🔍 Latest deploy log https://app.netlify.com/sites/label-studio-docs-new-theme/deploys/6565ddabdc797a0008dd420d

Copy link

netlify bot commented Nov 23, 2023

Deploy Preview for heartex-docs canceled.

Name Link
🔨 Latest commit 42fa252
🔍 Latest deploy log https://app.netlify.com/sites/heartex-docs/deploys/6565ddabf6b5fe00088fcce2

@github-actions github-actions bot added the fix label Nov 23, 2023
Copy link

codecov bot commented Nov 23, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (caa6f23) 76.03% compared to head (42fa252) 76.03%.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #5080   +/-   ##
========================================
  Coverage    76.03%   76.03%           
========================================
  Files          154      154           
  Lines        12792    12792           
========================================
  Hits          9726     9726           
  Misses        3066     3066           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bmartel bmartel merged commit 6efe443 into develop Nov 28, 2023
35 checks passed
@bmartel bmartel deleted the fb-optic-45 branch November 28, 2023 19:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants