Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: OPTIC-184: Revert "feat: OPTIC-184: Remove is_deleted field from User model and manager" #5168

Merged
merged 1 commit into from
Dec 8, 2023
Merged

fix: OPTIC-184: Revert "feat: OPTIC-184: Remove is_deleted field from User model and manager" #5168

merged 1 commit into from
Dec 8, 2023

Conversation

dredivaris
Copy link
Contributor

Reverts #5125

@netlify Netlify
Copy link

netlify bot commented Dec 8, 2023 •
edited
Loading

✅ Deploy Preview for label-studio-docs-new-theme canceled.

Name Link
🔨 Latest commit 9a39265
🔍 Latest deploy log https://app.netlify.com/sites/label-studio-docs-new-theme/deploys/657392b9c8d93a0008f961f7

@netlify Netlify
Copy link

netlify bot commented Dec 8, 2023 •
edited
Loading

✅ Deploy Preview for heartex-docs canceled.

Name Link
🔨 Latest commit 9a39265
🔍 Latest deploy log https://app.netlify.com/sites/heartex-docs/deploys/657392b912b4480008039d79

@codecov Codecov
Copy link

codecov bot commented Dec 8, 2023 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (32eeea4) 76.11% compared to head (9a39265) 76.12%.

Additional details and impacted files 
@@             Coverage Diff             @@
##           develop    #5168      +/-   ##
===========================================
+ Coverage    76.11%   76.12%   +0.01%     
===========================================
  Files          154      154              
  Lines        12819    12829      +10     
===========================================
+ Hits          9757     9766       +9     
- Misses        3062     3063       +1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

jombooth
jombooth approved these changes Dec 8, 2023
View reviewed changes
Copy link
Contributor

@jombooth jombooth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks again

@dredivaris dredivaris changed the title Revert "feat: OPTIC-184: Remove is_deleted field from User model and manager" fix: OPTIC-184: Revert "feat: OPTIC-184: Remove is_deleted field from User model and manager" Dec 8, 2023
@dredivaris dredivaris merged commit 52afd31 into develop Dec 8, 2023
36 of 37 checks passed
jombooth added a commit that referenced this pull request Dec 12, 2023
@jombooth
Revert "fix: OPTIC-184: Revert "feat: OPTIC-184: Remove is_deleted fi…
41e0b20 
…eld from User model and manager" (#5168)"

This reverts commit 52afd31.
jombooth added a commit that referenced this pull request Dec 12, 2023
@jombooth
chore: Revert "fix: OPTIC-184: Revert "feat: OPTIC-184: Remove is_del…
d3e3897 
…eted fi… (#5182)

Revert "fix: OPTIC-184: Revert "feat: OPTIC-184: Remove is_deleted field from User model and manager" (#5168)"

This reverts commit 52afd31.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bmartel bmartel bmartel approved these changes

@jombooth jombooth jombooth approved these changes

Assignees
No one assigned
Labels
fix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@dredivaris @bmartel @jombooth