Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: LEAP-463: Nearly empty diff to trigger followmerge #5181

Merged
merged 2 commits into from
Dec 12, 2023

Conversation

jombooth
Copy link
Contributor

PR fulfills these requirements

  • Commit message(s) and PR title follows the format [fix|feat|ci|chore|doc]: TICKET-ID: Short description of change made ex. fix: DEV-XXXX: Removed inconsistent code usage causing intermittent errors
  • Tests for the changes have been added/updated (for bug fixes/features)
  • Docs have been added/updated (for bug fixes/features)
  • Best efforts were made to ensure docs/code are concise and coherent (checked for spelling/grammatical errors, commented out code, debug logs etc.)
  • Self-reviewed and ran all changes on a local instance (for bug fixes/features)

Change has impacts in these area(s)

(check all that apply)

  • Product design
  • Backend (Database)
  • Backend (API)
  • Frontend

Describe the reason for change

(link to issue, supportive screenshots etc.)

What does this fix?

(if this is a bug fix)

What is the new behavior?

(if this is a breaking or feature change)

What is the current behavior?

(if this is a breaking or feature change)

What libraries were added/updated?

(list all with version changes)

Does this change affect performance?

(if so describe the impacts positive or negative)

Does this change affect security?

(if so describe the impacts positive or negative)

What alternative approaches were there?

(briefly list any if applicable)

What feature flags were used to cover this change?

(briefly list any if applicable)

Does this PR introduce a breaking change?

(check only one)

  • Yes, and covered entirely by feature flag(s)
  • Yes, and covered partially by feature flag(s)
  • No
  • Not sure (briefly explain the situation below)

What level of testing was included in the change?

(check all that apply)

  • e2e
  • integration
  • unit

Which logical domain(s) does this change affect?

(for bug fixes/features, be as precise as possible. ex. Authentication, Annotation History, Review Stream etc.)

Copy link

netlify bot commented Dec 12, 2023

Deploy Preview for label-studio-docs-new-theme canceled.

Name Link
🔨 Latest commit 84a79d8
🔍 Latest deploy log https://app.netlify.com/sites/label-studio-docs-new-theme/deploys/6578b7d824d0d100082d85d1

Copy link

netlify bot commented Dec 12, 2023

Deploy Preview for heartex-docs canceled.

Name Link
🔨 Latest commit 84a79d8
🔍 Latest deploy log https://app.netlify.com/sites/heartex-docs/deploys/6578b7d86ab3f60008e5aeb1

@github-actions github-actions bot added the chore label Dec 12, 2023
@jombooth jombooth marked this pull request as draft December 12, 2023 19:37
@jombooth jombooth marked this pull request as ready for review December 12, 2023 19:37
@jombooth jombooth changed the title chore: LEAP-463: Empty commit to trigger followmerge chore: LEAP-463: Nearly empty diff to trigger followmerge Dec 12, 2023
Copy link

codecov bot commented Dec 12, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (517d442) 76.12% compared to head (84a79d8) 76.12%.
Report is 12 commits behind head on develop.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #5181   +/-   ##
========================================
  Coverage    76.12%   76.12%           
========================================
  Files          154      154           
  Lines        12829    12829           
========================================
  Hits          9766     9766           
  Misses        3063     3063           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jombooth jombooth merged commit 1ce70cc into develop Dec 12, 2023
37 checks passed
@jombooth jombooth deleted the fb-LEAP-463/empty branch December 12, 2023 19:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant