Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: LEAP-908: Fix condition for Starter Cloud to fix DM #5646

Merged
merged 2 commits into from
Mar 28, 2024
Merged

fix: LEAP-908: Fix condition for Starter Cloud to fix DM #5646

merged 2 commits into from
Mar 28, 2024

Conversation

hlomzik
Copy link
Collaborator

@hlomzik hlomzik commented Mar 28, 2024 •
edited
Loading

Couple of fixes on how we check for expired Starter Cloud:

  • main condition for Starter Cloud
  • check that billing exists (it doesn't in Open Source)
  • don't check for expiration in non Starter Cloud setup

Describe the reason for change

DM was crashing on load because of missed billing

What feature flags were used to cover this change?

fflag_feat_front_leap_482_self_serve_short

This change affects (describe how if yes)

  • Performance
  • Security
  • UX

Does this PR introduce a breaking change?

  • Yes, and covered entirely by feature flag(s)
  • Yes, and covered partially by feature flag(s)
  • No
  • Fixes breaking change

@github-actions github-actions bot added the fix label Mar 28, 2024
@netlify Netlify
Copy link

netlify bot commented Mar 28, 2024 •
edited
Loading

✅ Deploy Preview for label-studio-docs-new-theme canceled.

Name Link
🔨 Latest commit 28c2814
🔍 Latest deploy log https://app.netlify.com/sites/label-studio-docs-new-theme/deploys/66056def6b8e630007540baf

@netlify Netlify
Copy link

netlify bot commented Mar 28, 2024 •
edited
Loading

✅ Deploy Preview for heartex-docs canceled.

Name Link
🔨 Latest commit 28c2814
🔍 Latest deploy log https://app.netlify.com/sites/heartex-docs/deploys/66056def10a56700082a80d4

@hlomzik hlomzik merged commit ec424bc into develop Mar 28, 2024
31 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bmartel bmartel bmartel approved these changes

@juliosgarbi juliosgarbi juliosgarbi approved these changes

@vladimirheartex vladimirheartex vladimirheartex approved these changes

Assignees
No one assigned
Labels
Confirmed fix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@hlomzik @bmartel @juliosgarbi @vladimirheartex @robot-ci-heartex